Re: [PATCH] Add tests for diff.color-words configuration option.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 20, 2009, 16:54 UTC
Message-ID: <alpine.DEB.1.00.0901201748230.5159@intel-tinevez-2-302>
In-Reply-To: <200901201034.22478.bss@iguanasuicide.net>

Hi,

On Tue, 20 Jan 2009, Boyd Stephen Smith Jr. wrote:

Show 10 quoted lines

> On Tuesday 2009 January 20 03:58:37 Johannes Schindelin wrote:
> >On Mon, 19 Jan 2009, Boyd Stephen Smith Jr. wrote:
> >> I'm not sure why the diff is crazy long.
> >
> >Because you changed things that need no changing, such as "cat > expect"
> >-> "cat > expect.blabla",
> 
> I suppose I could have gotten away with doing this differently, but I 
> did need to save off some of those results to different files because I 
> wanted to resuse the results.

Why didn't you do that, then?

	cp expect expect.for-later-use

> >and because you inserted your test instead of adding it at the end.
> 
> I put the tests in that order explicitly to test that .gitattributes 
> overrides the configuration option.

Why not just remove the .gitattributes for your second test?

It would be much clearer that you did not modify any existing tests, then.

Ciao, Dscho