Re: [PATCH v5 02/17] object-store: rename `object_directory` to `odb_source`

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 1, 2025, 12:17 UTC
Message-ID: <aGPR8K_WxZj7jJvk@pks.im>
In-Reply-To: <yeimqezalnffifo57opsmngxdyggu2rv53mj3plp5alx37j6pl@slkxiv4brpso>

On Sun, Jun 29, 2025 at 09:02:04PM -0500, Justin Tobler wrote:

Show 9 quoted lines

> On 25/06/05 08:46AM, Patrick Steinhardt wrote:
> [snip]
> > -struct object_directory *find_odb(struct repository *r, const char *obj_dir)
> > +struct odb_source *find_odb(struct repository *r, const char *obj_dir)
> 
> Since we renamed `object_directory` to `odb_source`, should instead call
> this function `find_odb_source`?
> 
> Otherwise, the renames in this patch look good to me.

The name gets adjusted to `odb_find_source()` in a later patch.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.