Re: [PATCH v5 08/17] odb: get rid of `the_repository` when handling alternates

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 1, 2025, 12:18 UTC
Message-ID: <aGPR_L__pP-4gBJl@pks.im>
In-Reply-To: <zsrwwg5mhxx7xk53i7czza5sageivnm2hxj5nlvunpe4gzrrjq@n5ne6qwovyom>

On Sun, Jun 29, 2025 at 09:56:05PM -0500, Justin Tobler wrote:

Show 10 quoted lines

> On 25/06/05 08:46AM, Patrick Steinhardt wrote:
> > all callers. The functions are renamed accordingly.
> > 
> > Note that right now the situation is still somewhat weird because we end
> > up using the path provided by the object store's repository anyway. This
> > will be adapted over time though so that we instead store the path to
> > the primary object directory in the object database itself.
> 
> Just to clarify, are we walking about the path to the alternate odb? I'm
> not quite sure I follow.

Yeah, this is phrased a bit weirdly. What I wanted to say is that we basically end up using `repo_git_path(odb->repo, ...)` anyway, so we could have just passed in the repository itself.

I'll rephrase the commit message a bit.

Patrick