Re: [PATCH v5 00/27] multi-pack reachability bitmaps

From: Jeff King <peff@peff.net>
Date: Sep 2, 2021, 09:45 UTC
Message-ID: <YTCdHHRW/i3HVN0h@coredump.intra.peff.net>
In-Reply-To: <cover.1630443072.git.me@ttaylorr.com>

On Tue, Aug 31, 2021 at 04:51:33PM -0400, Taylor Blau wrote:

Show 15 quoted lines

> This series resolves that discussion by leaving everything as-is, and only
> changing the following:
> 
>   - `git multi-pack-index` will not run when outside of a Git
>     repository.
> 
>   - The `--object-dir` argument will only recognize object directories
>     belonging to an alternate of the current repository.
> 
>   - Using `--object-dir` to point to a repository which uses a
>     different hash than the repository in the current working directory
>     will continue to not work (as was the case before this series).
> 
> And because this incorporates [1], we will also not accidentally clean `.rev`
> files from the wrong object directory.

Thanks. I read over the new patches, and all looks good to me (using the revised patch 11 you already sent, and which I commented on separately).

-Peff