Re: [PATCH 02/22] pack-bitmap-write.c: gracefully fail to write non-closed bitmaps

From: Jonathan Tan <jonathantanmy@google.com>
Date: Apr 16, 2021, 02:46 UTC
Message-ID: <20210416024657.17563-1-jonathantanmy@google.com>
In-Reply-To: <d199954ef2246165f32a4f703d1e0ebf43847152.1617991824.git.me@ttaylorr.com>

Show 6 quoted lines

> @@ -125,15 +125,20 @@ static inline void push_bitmapped_commit(struct commit *commit)
>  	writer.selected_nr++;
>  }
>  
> -static uint32_t find_object_pos(const struct object_id *oid)
> +static uint32_t find_object_pos(const struct object_id *oid, int *found)

find_object_pos() is only called by fill_bitmap_tree() and fill_bitmap_commit(). fill_bitmap_tree() is only called by itself and fill_bitmap_commit(). fill_bitmap_commit() is only called by bitmap_writer_build(). And bitmap_writer_build() is only called by write_pack_file(), which has been changed to die when bitmap_writer_build() fails. So looks like everything is accounted for.