Re: [PATCH v2 06/24] midx: make a number of functions non-static

From: Taylor Blau <me@ttaylorr.com>
Date: Jul 14, 2021, 23:01 UTC
Message-ID: <YO9s3NM8CYtbbo82@nand.local>
In-Reply-To: <878s2yzv65.fsf@evledraar.gmail.com>

On Fri, Jun 25, 2021 at 01:42:06AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 9 quoted lines

>
> On Mon, Jun 21 2021, Taylor Blau wrote:
>
> > These functions will be called from outside of midx.c in a subsequent
> > patch.
>
> So "a number" is "two" and "a subsequent patch" appears to be 13/24. I
> think this would be clearer just squashed into whatever needs it, or at
> least if it comes right before the new use in the series.

Good suggestion, thanks. This was probably written at a time when the number of functions I needed was larger (or perhaps when this and patches 10-12 were all jumbled together).

In any case, I dropped this patch and squashed its contents into 13/24 where it is used.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.