Re: [PATCH v4 05/25] midx: clear auxiliary .rev after replacing the MIDX

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 24, 2021, 21:24 UTC
Message-ID: <YSVjnSDaBXgXvT9W@nand.local>
In-Reply-To: <xmqqr1eimtrp.fsf@gitster.g>

On Tue, Aug 24, 2021 at 02:12:42PM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
>
> >> This needs to take object_dir into account, no?
> >
> > Yes and no; clear_midx_files_ext() still takes a pointer to a 'struct
> > repository' until we pick up [1].
>
> I was hoping that [1] will become part of this series as a trivial
> clean-up and bugfix, perhaps in its early part.

Sure, that works even better. I'll send a reroll incorporating it as soon as I finish re-testing.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.