Re: [PATCH v3 00/25] multi-pack reachability bitmaps

From: Jeff King <peff@peff.net>
Date: Aug 12, 2021, 21:21 UTC
Message-ID: <YRWQ6G/dYJC5Of1q@coredump.intra.peff.net>
In-Reply-To: <cover.1627420428.git.me@ttaylorr.com>

On Tue, Jul 27, 2021 at 05:19:21PM -0400, Taylor Blau wrote:

> Thanks in advance for your review. I think Peff still wanted to read through
> patches 16-25, but that the first 15 or so should be in pretty good shape by
> now.

I think this is looking pretty close. There's the close_midx() thing discussed in patch 9 that I think we need to deal with. In the tests, I found some little nits. Nothing serious, but some of it at least is worth fixing.

So I think with one more fairly trivial re-roll, we can think about merging this to 'next'.

Thanks for your patience with my slow reviews, and for all your work on this. It's really quite a complicated topic. :)

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.