Re: [PATCH v2 07/24] midx: clear auxiliary .rev after replacing the MIDX

From: Jeff King <peff@peff.net>
Date: Jul 21, 2021, 10:19 UTC
Message-ID: <YPf0yduzM9ReOYfX@coredump.intra.peff.net>
In-Reply-To: <1448ca0d2ba265db2dce414a7f7d6b1f4bcb5a08.1624314293.git.me@ttaylorr.com>

On Mon, Jun 21, 2021 at 06:25:15PM -0400, Taylor Blau wrote:

Show 8 quoted lines

> When writing a new multi-pack index, write_midx_internal() attempts to
> clean up any auxiliary files (currently just the MIDX's `.rev` file, but
> soon to include a `.bitmap`, too) corresponding to the MIDX it's
> replacing.
> 
> This step should happen after the new MIDX is written into place, since
> doing so beforehand means that the old MIDX could be read without its
> corresponding .rev file.

Good catch. The patch looks obviously correct.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.