Re: [PATCH v2 00/24] multi-pack reachability bitmaps

From: Jeff King <peff@peff.net>
Date: Jul 21, 2021, 12:12 UTC
Message-ID: <YPgPNVfwedWFGqcd@coredump.intra.peff.net>
In-Reply-To: <YPBIBXUB53b0Hixx@nand.local>

On Thu, Jul 15, 2021 at 10:36:53AM -0400, Taylor Blau wrote:

> I know that reviewing this is on Peff's list of things to do, but there
> are competing priorities (and we have all-company meetings this week, so
> I would not be surprised to see a lack of movement until at least next
> week).

I made it through a very careful read of all of the actual code changes, through patch 14. After that, it looks like it's all tests, but my brain is now effectively fried. I had some comments, but nothing earth-shattering.

I'll pick up on 15-24 later, though I think between my comments and Ævar's there's some light changes to be made. So don't hesitate to post a new version in the meantime, which can save us a round-trip.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.