Re: [PATCH v2 12/24] pack-bitmap.c: introduce 'bitmap_is_preferred_refname()'
- From
Jeff King <peff@peff.net>
- Date
- Jul 21, 2021, 10:39 UTC
- Message-ID
- <YPf5a4LzBwNweI3W@coredump.intra.peff.net>
- In-Reply-To
- <c474d2eda5b0b4393616109915626134429085d5.1624314293.git.me@ttaylorr.com>
On Mon, Jun 21, 2021 at 06:25:29PM -0400, Taylor Blau wrote:
Show 12 quoted lines
> In a recent commit, pack-objects learned support for the > 'pack.preferBitmapTips' configuration. This patch prepares the > multi-pack bitmap code to respect this configuration, too. > > Since the multi-pack bitmap code already does a traversal of all > references (in order to discover the set of reachable commits in the > multi-pack index), it is more efficient to check whether or not each > reference is a suffix of any value of 'pack.preferBitmapTips' rather > than do an additional traversal. > > Implement a function 'bitmap_is_preferred_refname()' which does just > that. The caller will be added in a subsequent patch.
I suspect there was some patch reordering here. We don't have any multi-pack bitmap code yet. :)
Probably this needs to say something like "in preparation for adding multi-pack bitmap code..." or similar?
-Peff