Re: [PATCH v2 04/24] Documentation: build 'technical/bitmap-format' by default
- From
Jeff King <peff@peff.net>
- Date
- Jul 23, 2021, 07:39 UTC
- Message-ID
- <YPpyLaM1Rc9+w6KT@coredump.intra.peff.net>
- In-Reply-To
- <YPhYFnudmHJ9lQek@nand.local>
On Wed, Jul 21, 2021 at 01:23:34PM -0400, Taylor Blau wrote:
Show 19 quoted lines
> > I don't know if it's better to have a poorly-formatted HTML file, or > > none at all. :) > > > > Personally, I would just read the source. And I have a slight concern > > that if we start "cleaning it up" to render as asciidoc, the source > > might end up a lot less readable (though I'd reserve judgement until > > actually seeing it). > > Yeah, the actual source is pretty readable (and it's what I had been > looking at, although it is sometimes convenient to have a version I can > read in my web browser). But it's definitely not good Asciidoc. > > I briefly considered cleaning it up, but decided against it. Usually I > would opt to clean it up, but this series is already so large that I > figured it would make a negative impact on the reviewer experience to > read a clean-up patch here. > > I wouldn't be opposed to coming back to it in the future, once the dust > settles. I guess we can consider this #leftoverbits until then.
Yeah, I definitely don't want to see that cleanup as a dependency for this series. It's already long enough as it is. Coming back to it later is just fine with me.
The question here is: should we continue to omit it from the html build, since it does not render well (i.e., should we simply drop this patch).
-Peff