Re: [PATCH v4 1/4] fsmonitor: add two new config options, allowRemote and socketDir
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Sep 6, 2022, 14:27 UTC
- Message-ID
- <664ece2e-b149-8058-5937-b726810a59da@jeffhostetler.com>
- In-Reply-To
- <BYAPR05MB5573AACF524A1319B8F1119CD97A9@BYAPR05MB5573.namprd05.prod.outlook.com>
On 9/2/22 12:54 PM, Eric DeCosta wrote:
Show 17 quoted lines
> > >> -----Original Message----- >> From: Jeff Hostetler <git@jeffhostetler.com> >> Sent: Thursday, September 1, 2022 5:22 PM >> To: Eric DeCosta via GitGitGadget <gitgitgadget@gmail.com>; >> git@vger.kernel.org >> Cc: Eric DeCosta <edecosta@mathworks.com> >> Subject: Re: [PATCH v4 1/4] fsmonitor: add two new config options, >> allowRemote and socketDir >> >> >> >> On 8/31/22 12:09 PM, Eric DeCosta via GitGitGadget wrote: >>> From: Eric DeCosta <edecosta@mathworks.com> >>> >>> Introduce two new configuration options
[...]
Show 8 quoted lines
>> 5. In fsm-settings-darwin.c:fsm_os__incompatible() >> complain if the socket path is remote (when is-ipc is set). >> >> This probably ought to be a new _REASON_ type for non-local >> UDS. And this is independent of whether the actual worktree >> is remote or whether remote worktrees are allowed. > > I thought that was what FSMONITOR_REASON_NOSOCKETS was for?
Yeah, I was probably juggling too many things in my head when I was making that list. And I'm sure it'll fall our when you see what the code looks like. The _NOSOCKETS case should basically be just the places where you test the path of the socket-dir (if it is always outside of the .git dir). None of the tests on the actual workdir inspection should hit it anymore, right?
And we can save for a later day whether or not to test for NTFS and FAT32 (local or remote) in the Darwin code based on whether or not the kernel sends FSEvents for them.
Jeff