Re: [PATCH] fsmonitor: option to allow fsmonitor to run against network-mounted repos

From: Torsten Bögershausen <tboegi@web.de>
Date: Aug 19, 2022, 18:58 UTC
Message-ID: <20220819185847.ulr5yjcfsahydeff@tb-raspi4>
In-Reply-To: <pull.1326.git.1660855703816.gitgitgadget@gmail.com>

On Thu, Aug 18, 2022 at 08:48:23PM +0000, Eric DeCosta via GitGitGadget wrote:

> From: Eric DeCosta <edecosta@mathworks.com>

Just some comments on the commit message, please see inline.

>
> Though perhaps not common, there are uses cases where users have large,
> network-mounted repos. Having the ability to run fsmonitor against
> network paths would benefit those users.

I think that we can drop the "Though perhaps not common" - it doesn't add any information about the technical part of the patch. (And that is, what is important)

And I personally use network-mounted repos every day ;-)

Sone users have large, network-mounted repos. Having the ability to run fsmonitor against network paths would benefit those users.

Show 6 quoted lines

>
> As a first step towards enabling fsmonitor to work against
> network-mounted repos, a configuration option, 'fsmonitor.allowRemote'
> was introduced for Windows. Setting this option to true will override
> the default behavior (erroring-out) when a network-mounted repo is
> detected by fsmonitor.

[] The same option is now introduced for macOS.

>
> The the added wrinkle being that the Unix domain socket (UDS) file

  ^^^ ^^^

> used for IPC cannot be created in a network location; instead the
> temporary directory is used.