Re: [PATCH v7 2/6] fsmonitor: relocate socket file if .git directory is remote

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 19, 2022, 17:49 UTC
Message-ID: <xmqq35cnb6fw.fsf@gitster.g>
In-Reply-To: <40b47246-adb6-cf56-02ef-25ab1429a42e@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

> Aren't we in the middle of a transition from always
> using the global "the_repository" to a passed "r" variable?
> We're getting closer to being able to hide the the global
> symbol, but we're not there yet, right?

We may still have code that works ONLY on the_repository, but letting a function take "r" and lettin it ignore is worse than leaving it explicitly limited to the_repository only, no?

> I'm thinking that at as long as the global exists, we are not
> safe to have multiple "struct repository" instances, right?

By itself, Not at all. It is the code like I am criticizing that makes it unsafe.

I do not mind adding

	if (!r)
		BUG(...);

at the place you have the "sweep it under the rug" band-aid, though.