Re: [PATCH] fsmonitor: option to allow fsmonitor to run against network-mounted repos

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 19, 2022, 17:48 UTC
Message-ID: <CAPig+cSwqNp5Jc7tcn7wLBHNCTHKYVzFs18KzVb+t9rRsrn1Fg@mail.gmail.com>
In-Reply-To: <pull.1326.git.1660855703816.gitgitgadget@gmail.com>

On Thu, Aug 18, 2022 at 5:00 PM Eric DeCosta via GitGitGadget <gitgitgadget@gmail.com> wrote:

> Though perhaps not common, there are uses cases where users have large,

s/uses cases/use cases/

Show 11 quoted lines

> network-mounted repos. Having the ability to run fsmonitor against
> network paths would benefit those users.
>
> As a first step towards enabling fsmonitor to work against
> network-mounted repos, a configuration option, 'fsmonitor.allowRemote'
> was introduced for Windows. Setting this option to true will override
> the default behavior (erroring-out) when a network-mounted repo is
> detected by fsmonitor. In order for macOS to have parity with Windows,
> the same option is now introduced for macOS.
>
> The the added wrinkle being that the Unix domain socket (UDS) file

s/The the/The/

> used for IPC cannot be created in a network location; instead the
> temporary directory is used.
>
> Signed-off-by: Eric DeCosta <edecosta@mathworks.com>