Re: [PATCH v15 0/6] fsmonitor: option to allow fsmonitor to run against network-mounted repos

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 5, 2022, 18:05 UTC
Message-ID: <xmqq35c2qh7u.fsf@gitster.g>
In-Reply-To: <pull.1326.v15.git.1664904751.gitgitgadget@gmail.com>

"Eric DeCosta via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 9 quoted lines

> An additional issue is that for mount points in the root directory, FSEvents
> does not report a path that matches the worktree directory due to the
> introduction of 'synthetic firmlinks'. fsmonitor must map the FSEvents paths
> to the worktree directory by interrogating the root filesystem for synthetic
> firmlinks and using that information to translate the path.
>
> v15 differs from v14:
>
>  * fix memory leak

Thanks. I thought "what, another iteration? didn't we see this enough times already?" and a note like this does help reminding reviewers why we need one.

Very much appreciated.