Re: [PATCH v4 2/4] fsmonitor: generate unique Unix socket file name in the desired location

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2022, 20:11 UTC
Message-ID: <xmqqzgfkdvga.fsf@gitster.g>
In-Reply-To: <2cb026a631704b004b06e4a944c79a434df08440.1661962145.git.gitgitgadget@gmail.com>

"Eric DeCosta via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines

> +const char *fsmonitor_ipc__get_path(void)
> +{
> +#ifdef WIN32
> +	return fsmonitor_ipc__get_default_path();
> +#else

Hmph.

As compat/fsmonitor/ directory already sets up a good way to have platform-specific implementation of a common API function, I think this patch goes in a wrong direction by fighting it.

Shouldn't the rest of the function we see here be made to another implementation of fsmonitor_ipc__get_default_path() that is specific to platforms, i.e. in compat/fsmonitor/$somenewfile.c, that is used for !WIN32 case?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.