Re: [PATCH v8 2/5] fsmonitor: relocate socket file if .git directory is remote

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 19, 2022, 16:58 UTC
Message-ID: <xmqqsfknb8sw.fsf@gitster.g>
In-Reply-To: <CAPig+cTRNfewL01GOVTjFLaFq-vGgdeV2OX6Bn+StGrgb1JVMA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 13 quoted lines

> A couple comments...
>
> In my mind, the directory specified by `fsmonitor.socketdir` is likely
> to be dedicated to this purpose (i.e. housing Git administrative
> junk). As such, it feels somewhat odd for the socket file to be
> hidden; I would instead expect the socket name to be non-hidden (say,
> "git-fsmonitor-daemon-{hash}.ipc") rather than hidden
> (".git-fsmonitor-*"). The directory specified by `fsmonitor.socketdir`
> may or may not be hidden (i.e. start with a dot), but that's the
> user's decision. For the $HOME case, it almost feels cleaner to create
> a hidden directory (say, "$HOME/.git-fsmonitor") in which to house the
> socket files ("git-fsmonitor-daemon-{hash}.ipc"). Anyhow, this comment
> is quite subjective; perhaps not actionable.

Yeah, dot-prefixed files are appropriate if they are to be placed at the top of some tree without the user having any say in how that tree is chosen (e.g. the working tree or $HOME). If the user has the power to specify the location, the equation changes.

Show 5 quoted lines

> What happens if either $HOME or `fsmonitor.socketdir` are
> network-mounted? Should this code be checking for that case? If they
> are network-mounted, should it error out? At minimum, I would think a
> warning is warranted in order to save users the headache of wondering
> why fsmonitor isn't working correctly.

That's a good point. If one default position (e.g. repository) is checked if it is usable and can be rejected if it isn't, the fallback position should at least satisfy the same "is it usable?" criteria.

Thanks.