From: Jeff Hostetler Date: Tue, 06 Sep 2022 14:27:23 GMT Subject: Re: [PATCH v4 1/4] fsmonitor: add two new config options, allowRemote and socketDir Message-ID: <664ece2e-b149-8058-5937-b726810a59da@jeffhostetler.com> In-Reply-To: On 9/2/22 12:54 PM, Eric DeCosta wrote: > > >> -----Original Message----- >> From: Jeff Hostetler >> Sent: Thursday, September 1, 2022 5:22 PM >> To: Eric DeCosta via GitGitGadget ; >> git@vger.kernel.org >> Cc: Eric DeCosta >> Subject: Re: [PATCH v4 1/4] fsmonitor: add two new config options, >> allowRemote and socketDir >> >> >> >> On 8/31/22 12:09 PM, Eric DeCosta via GitGitGadget wrote: >>> From: Eric DeCosta >>> >>> Introduce two new configuration options [...] >> 5. In fsm-settings-darwin.c:fsm_os__incompatible() >> complain if the socket path is remote (when is-ipc is set). >> >> This probably ought to be a new _REASON_ type for non-local >> UDS. And this is independent of whether the actual worktree >> is remote or whether remote worktrees are allowed. > > I thought that was what FSMONITOR_REASON_NOSOCKETS was for? Yeah, I was probably juggling too many things in my head when I was making that list. And I'm sure it'll fall our when you see what the code looks like. The _NOSOCKETS case should basically be just the places where you test the path of the socket-dir (if it is always outside of the .git dir). None of the tests on the actual workdir inspection should hit it anymore, right? And we can save for a later day whether or not to test for NTFS and FAT32 (local or remote) in the Darwin code based on whether or not the kernel sends FSEvents for them. Jeff