Re: [PATCH v3 0/2] fsmonitor: option to allow fsmonitor to run against network-mounted repos
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 24, 2022, 16:46 UTC
- Message-ID
- <xmqqfshl8u9h.fsf@gitster.g>
- In-Reply-To
- <pull.1326.v3.git.1661280941.gitgitgadget@gmail.com>
"Eric DeCosta via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 9 quoted lines
> cc: Johannes Schindelin Johannes.Schindelin@gmx.de cc: Jeff Hostetler > git@jeffhostetler.com cc: Eric Sunshine sunshine@sunshineco.com cc: Torsten > Bögershausen tboegi@web.de > > Eric DeCosta (1): > fsmonitor: macOS: allow fsmonitor to run against network-mounted repos > > edecosta (1): > Check working directory and Unix domain socket file for compatability
Please describe why v3 exists (iow, what was wrong in v2 that v3 improves) in the cover letter. Especially when you send out two revisions in less than 12 hours, it gets disorienting at the receiving end.
Thanks.
Show 19 quoted lines
> compat/fsmonitor/fsm-settings-darwin.c | 72 +++++++++++++++++++------- > fsmonitor-ipc.c | 40 ++++++++++++-- > fsmonitor-ipc.h | 6 +++ > fsmonitor-settings.c | 67 +++++++++++++++++++++++- > fsmonitor-settings.h | 4 ++ > 5 files changed, 164 insertions(+), 25 deletions(-) > > > base-commit: 795ea8776befc95ea2becd8020c7a284677b4161 > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1326%2Fedecosta-mw%2Ffsmonitor_macos-v3 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1326/edecosta-mw/fsmonitor_macos-v3 > Pull-Request: https://github.com/gitgitgadget/git/pull/1326 > > Range-diff vs v2: > > 1: 40ce21e85c9 < -: ----------- fsmonitor: option to allow fsmonitor to run against network-mounted repos > 2: 46b4efd96cc = 1: cd16d8bb3d6 fsmonitor: macOS: allow fsmonitor to run against network-mounted repos > 3: 9b128a98149 = 2: f977d140afa Check working directory and Unix domain socket file for compatability > 4: 15c965801f8 < -: ----------- Minor refactoring and simplification of Windows settings checks