Re: [PATCH v7 01/10] fsmonitor: fix khash memory leak in do_handle_client

From: Paul Tarjan <paul@paultarjan.com>
Date: Mar 4, 2026, 18:17 UTC
Message-ID: <20260304181740.25613-1-github@paulisageek.com>
In-Reply-To: <aafiaS-DscdIkori@pks.im>

On Tue, Mar 4, 2026, Patrick Steinhardt wrote:

> Makes sense. If I understood correctly I think we could improve this
> code to stop using khash directly and instead use a strmap, which
> has a nicer interface. But that's certainly outside of the scope of this
> patch series and rather a #leftoverbit.

Went ahead and did this in v8 as patch 12. Switched to strset (since we only need a set, not a map). Ended up being a nice simplification: strset_add() returns whether the entry is new, so the lookup+insert becomes a single call.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.