Re: [PATCH v11 0/8] fsmonitor: add Linux support using inotify

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 31, 2026, 16:05 UTC
Message-ID: <xmqqikac2dcq.fsf@gitster.g>
In-Reply-To: <20260331061754.83335-1-github@paulisageek.com>

Paul Tarjan <paul@paultarjan.com> writes:

Show 17 quoted lines

> I reproduced this in a Fedora container by merging fsmonitor-linux
> into seen and running t9210 with GIT_TEST_SPLIT_INDEX=yes. Fails
> without the fix, passes with it.
>
> Fix is pushed as a new commit at the end of the series:
>
>   fsmonitor_ewah_callback():
>   -  assert_index_minimum(istate, pos + 1);
>   +  if (pos >= istate->cache_nr)
>   +      return;
>
>   tweak_fsmonitor():
>   -  assert_index_minimum(istate, istate->fsmonitor_dirty->bit_size);
>   +  if (!istate->split_index)
>   +      assert_index_minimum(istate, istate->fsmonitor_dirty->bit_size);
>
> Paul

Thanks for a quick turnaround.

If it is a preexisting breakage in the original and not what you introduced, wouldn't it make sense to apply the fix very early in the series of patches, instead of patching breakage on top? If we queue on top of what we have in 'seen', this topic will still be broken up to [8/9] in the same place, breaking bisectability, and fixed only when the last patch is applied.