Re: [PATCH v7 08/10] fsmonitor: add tests for Linux

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 4, 2026, 07:43 UTC
Message-ID: <aafikA4bQS3lB0Hq@pks.im>
In-Reply-To: <fad2f0a81ab5fcdced2cdf3c02877fbb00244efa.1772065643.git.gitgitgadget@gmail.com>

On Thu, Feb 26, 2026 at 12:27:21AM +0000, Paul Tarjan via GitGitGadget wrote:

Show 8 quoted lines

> From: Paul Tarjan <github@paulisageek.com>
> 
> Add a smoke test that verifies the filesystem actually delivers
> inotify events to the daemon.  On some configurations (e.g.,
> overlayfs with older kernels), inotify watches succeed but events
> are never delivered.  The daemon cookie wait will time out, but
> every subsequent test would fail.  Skip the entire test file early
> when this is detected.

Hm. So the fsmonitor listener for Linux is not reliable? Wouldn't the end user see the same issue then? I'm not sure whether just ignoring that issue and adding a timeout to our tests is the proper way to fix it.

Before we jump to such solutions I'd rather want to know what the root cause of this. We had similar issues in the past on macOS, where we eventually figured out that we were missing events due to the buffers not being big enough. So did you investigate what the conditions are to trigger this?

Patrick