Re: [PATCH v15 00/13] fsmonitor: implement filesystem change listener for Linux
- From
D. Ben Knoble <ben.knoble@gmail.com>
- Date
- May 12, 2026, 20:36 UTC
- Message-ID
- <CALnO6CBOY6xk_sWeqtwWJXp9UPbY0Opd8Af1xk-j3QbdAtbOOw@mail.gmail.com>
- In-Reply-To
- <xmqqa4u5nnxq.fsf@gitster.g>
On Tue, May 12, 2026 at 2:26 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 27 quoted lines
> > Ben Knoble <ben.knoble@gmail.com> writes: > > >> Le 15 avr. 2026 à 09:27, Paul Tarjan via GitGitGadget <gitgitgadget@gmail.com> a écrit : > >> > >> This series implements the built-in fsmonitor daemon for Linux using the > >> inotify API, bringing it to feature parity with the existing Windows and > >> macOS implementations. It also fixes two memory leaks in the > >> platform-independent daemon code and deduplicates the IPC and settings logic > >> that is now shared between macOS and Linux. > > > > Troubleshooting a Gentoo build failure of next has me pretty > > convinced this topic is in there already. Junio should probably > > check my math, but I think that means we want to see fixes on top > > of that base now (unless we are reverting this topic from next and > > queuing a new version?). > > > > (The failure is a Gentoo-ism; we carry a patch that stops applying > > with this series. Not anything this project needs to worry about.) > > So is there a verdict already, which this project may not need to > worry about? This has been kept out of 'next' after getting > reverted but if the breakage was due to Gentoo-ism whose workaround > does not need to get upstreamed, and if there are no other reasons to > block the topic, I am inclined to mark the topic for 'next'. > > Thanks.
I think Gentoo folks know what needs done (which I will try to spend some time on soon) to adjust the patches we carry. (That will not need to get upstreamed, no.)
I would certainly not keep this out of the tree only on behalf of Gentoo, unless there are other issues.
-- D. Ben Knoble