Re: [PATCH v6 06/10] fsmonitor: deduplicate settings logic for Unix platforms
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 25, 2026, 21:31 UTC
- Message-ID
- <xmqqms0w8q8p.fsf@gitster.g>
- In-Reply-To
- <39da1e6be359a23ddad8f099d427823a774324f7.1772050636.git.gitgitgadget@gmail.com>
"Paul Tarjan via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 14 quoted lines
> From: Paul Tarjan <github@paulisageek.com> > > The fsmonitor settings logic for checking Unix domain socket > compatibility is nearly identical between macOS and Linux. Both check > whether the IPC socket directory resides on a remote filesystem or a > filesystem that does not support Unix domain sockets (NTFS, FAT32, etc). > > Merge the two implementations into a single fsm-settings-unix.c shared > by both platforms. The unified version uses the safer xstrdup() + > dirname() approach from the macOS implementation (avoiding strbuf > mutation with dirname()) and includes the "vfat" filesystem check. > > Update Makefile, meson.build, and CMakeLists.txt to use the new shared > file for non-Windows platforms.
I guess exactly the same comment as the one for 05/10 applies here as well?