Re: [PATCH v8 09/12] run-command: add close_fd_above_stderr option

From: Paul Tarjan <paul@paultarjan.com>
Date: Mar 5, 2026, 00:49 UTC
Message-ID: <20260305004959.83647-1-github@paulisageek.com>
In-Reply-To: <xmqq8qc771zf.fsf@gitster.g>

On Wed, Mar 4, 2026, Junio C Hamano wrote:

> I wonder if a generic callback function
> to call here in the child between fork and exec that the caller can
> supply would be a good thing to have.

Done in v9. Replaced the close_fd_above_stderr flag with a pre_exec_cb function pointer on struct child_process. The fd-closing logic is now a standalone close_fd_above_stderr() function that the two fsmonitor callers pass as the callback.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.