Re: [PATCH v6 05/10] fsmonitor: deduplicate IPC path logic for Unix platforms

From: Paul Tarjan <paul@paultarjan.com>
Date: Feb 27, 2026, 06:31 UTC
Message-ID: <20260227063128.9135-1-github@paulisageek.com>
In-Reply-To: <xmqqqzq88q9u.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> But the patch seems to indicate somewhat different story.  The code
> before this patch started with a single macOS (darwin) one, but
> because it is mostly applicable to other UNIX variants as well, the
> patch renames the existing macOS one for unix and makes a small
> adjustment (namely, asserts that r->worktree is not NULL).

Good point. Restructured: FSMONITOR_OS_SETTINGS is now set to "unix" for both macOS and Linux (and "win32" for Windows). The build files use $(FSMONITOR_OS_SETTINGS) for fsm-ipc and fsm-settings, and $(FSMONITOR_DAEMON_BACKEND) for the platform-specific files (listen, health, path-utils). No more if/else blocks.

Also rewrote both commit messages to describe what's actually happening (renaming darwin to unix) rather than "merging two implementations".

Thanks, Paul