Re: [PATCH v13 01/13] t9210: disable GIT_TEST_SPLIT_INDEX for scalar clone tests
Junio C Hamano <gitster@pobox.com> writes:
Show 20 quoted lines
> "Paul Tarjan via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Paul Tarjan <github@paulisageek.com>
>>
>> index.skipHash (Scalar default) and split-index are incompatible:
>> the shared index gets a null OID when skipHash skips computing the
>> hash, and the null OID causes the shared index to not be loaded on
>> re-read. This triggers a BUG assertion in fsmonitor when the
>> fsmonitor_dirty bitmap references more entries than the (now empty)
>> index has.
>>
>> Disable GIT_TEST_SPLIT_INDEX in the scalar clone tests that hit
>> this, matching the existing workaround in test 16.
>>
>> Signed-off-by: Paul Tarjan <github@paulisageek.com>
>> ---
>> t/t9210-scalar.sh | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
> The same treatment is needed for t9211, I suspect.
Not just "suspect", but it does break exactly at t9211.
https://github.com/git/git/actions/runs/24060447371/job/70175464363
Show 20 quoted lines
>
> --- >8 ---
> #!/bin/sh
>
> export OPENSSL_SHA1_UNSAFE=YesPlease
> export GIT_TEST_SPLIT_INDEX=yes
> export GIT_TEST_FULL_IN_PACK_ARRAY=true
> export GIT_TEST_OE_SIZE=10
> export GIT_TEST_OE_DELTA_SIZE=5
> export GIT_TEST_COMMIT_GRAPH=1
> export GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS=1
> export GIT_TEST_MULTI_PACK_INDEX=1
> export GIT_TEST_MULTI_PACK_INDEX_WRITE_INCREMENTAL=1
> export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master
> export GIT_TEST_NO_WRITE_REV_INDEX=1
> export GIT_TEST_CHECKOUT_WORKERS=2
> export GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL=1
>
> make && cd t && sh t9211-*.sh
> --- 8< ---
Junio C Hamano <gitster@pobox.com>