From: Paul Tarjan <paul@paultarjan.com>
Date: Wed, 04 Mar 2026 18:17:40 GMT
Subject: Re: [PATCH v7 01/10] fsmonitor: fix khash memory leak in do_handle_client
Message-ID: <20260304181740.25613-1-github@paulisageek.com>
In-Reply-To: <aafiaS-DscdIkori@pks.im>

On Tue, Mar 4, 2026, Patrick Steinhardt wrote:
> Makes sense. If I understood correctly I think we could improve this
> code to stop using khash directly and instead use a strmap, which
> has a nicer interface. But that's certainly outside of the scope of this
> patch series and rather a #leftoverbit.

Went ahead and did this in v8 as patch 12. Switched to strset
(since we only need a set, not a map). Ended up being a nice
simplification: strset_add() returns whether the entry is new, so
the lookup+insert becomes a single call.