Re: [PATCH v7 06/10] fsmonitor: deduplicate settings logic for Unix platforms

From

PTPaul Tarjan <paul@paultarjan.com>

Date

Mar 4, 2026, 18:17 UTC

Message-ID

<20260304181749.25711-1-github@paulisageek.com>

In-Reply-To

<aafihm4MVoVOaD2l@pks.im>

On Tue, Mar 4, 2026, Patrick Steinhardt wrote:

> It's a bit weird that the only change to the Makefile here is to change
> how we wire up fsm-ipc even though it's fsm-settings that this commit
> cares about. Should this change be moved into the preceding commit?

> Same here, it's not clear to me where those while-at-it changes are
> coming from and whether we need them here. I'd rather drop them.

Dropped. Both renames are now pure renames with no content changes.

> I think it might make sense to introduce the `fsmonitor_os` variable in
> the preceding commit already.

Done, fsmonitor_os is introduced in the IPC rename commit now.

> We could avoid the flip-flopping of the code here.