From: Bradley M. Kuhn Date: Tue, 20 Oct 2020 21:44:31 GMT Subject: Re: [PATCH v3 2/4] Documentation: clarify and expand description of --signoff Message-ID: <20201020214431.GA1398231@ebb.org> In-Reply-To: <418d15c53268f947e11dac2f22d1f8c3c8c60997.1603155607.git.bkuhn@sfconservancy.org> Junio, Junio wrote in the sub-thread about [PATCH v3 4/4]: >> It seems the patches [1-3/4] are identical to what has been queued >> in 'seen', which is a good sign. One change I made in v3 patchset was to add Peff's Signed-off-by, as it is *not* there in commit 04c2b9ebd0 in seen: I wrote in [PATCH v3 2/4]: > Signed-off-by: Jeff King … given that Peff made edits to this before it was posted, I think we want to be sure Peff's Signed-off-by is included. It just seems like the "right thing" to get the Signed-off-by trailers 100% correct on a commit that changes the description of Signed-off-by. 😆 I wrote in [PATCH v3 2/4]: > Reviewed-by: Taylor Blau I doubt Taylor cares whether this Reviewed-by trailer makes it in, but I did add that too based on Taylor providing it earlier in the discussion of this patch. ☺ -- Bradley M. Kuhn - he/him Policy Fellow & Hacker-in-Residence at Software Freedom Conservancy ======================================================================== Become a Conservancy Supporter today: https://sfconservancy.org/supporter