Re: [PATCH v2] t5411: consistent result for proc-receive broken test
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 10, 2020, 21:00 UTC
- Message-ID
- <xmqqzh3p53lt.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CANYiYbH-x6khgTkkFV29+7AjghOZmG69_6-sQcm2489WMHOWAA@mail.gmail.com>
Jiang Xin <worldhello.net@gmail.com> writes:
> Thanks Peff for pointing the root cause. Will use the "gently" forms > of packet_write_fmt() and packet_flush() in patch v3.
Another thing I noticed. Its tests are based on a codebase where master is called main, which means it is not designed to be usable with the 'master' or 'maint' track.
Because the topic is no longer "just apply a band-aid to paper over test flakeyness" but is fixing the codepath that matters in real user experience, I'd prefer to see it applicable even to the maintenance track.
Thanks.