Re: [PATCH v5 2/6] receive-pack: add new proc-receive hook
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 31, 2020, 00:19 UTC
- Message-ID
- <xmqqy2rh74w6.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200330165754.19195-3-worldhello.net@gmail.com>
Jiang Xin <worldhello.net@gmail.com> writes:
> + argv[0] = find_hook("proc-receive");
> + if (!argv[0]) {
> + rp_error("cannot to find hook 'proc-receive'");Perhaps discard "to" from here. Also I notice that other messages given to rp_error() are marked for _(i18n), but this one is not.
Show 14 quoted lines
> + make_user_friendly_and_stable_output <out >actual && > + cat >expect <<-EOF && > + remote: # pre-receive hook > + remote: pre-receive< <ZERO-OID> <COMMIT-A> refs/heads/next > + remote: pre-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic > + remote: error: cannot to find hook "proc-receive" > + remote: # post-receive hook > + remote: post-receive< <ZERO-OID> <COMMIT-A> refs/heads/next > + To ../upstream > + * [new branch] HEAD -> next > + ! [remote rejected] HEAD -> refs/for/master/topic (fail to run proc-receive hook) > + error: failed to push some refs to "../upstream" > + EOF > + test_cmp expect actual &&
This breaks gettext-poison test.
See https://travis-ci.org/github/git/git/jobs/669008025 for example.