git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v13 4/8] send-pack: extension for client-side status report

From
Jiang Xin <worldhello.net@gmail.com>
Date
Apr 18, 2020, 16:03 UTC
Message-ID
<20200418160334.15631-5-worldhello.net@gmail.com>
In-Reply-To
<20200414123257.27449-1-worldhello.net@gmail.com>
From: Jiang Xin <zhiyou.jx@alibaba-inc.com>
This is the client-side extension for status report of git-push.

The "proc-receive" hook may receive a command for a pseudo-reference with a zero-old as its old-oid, while the result of the hook may point to an alternate reference and the reference may exist already with a non-zero old-oid. Git client may receive a report with extened status as the following example:

    ok refs/for/master/topic\0ref=refs/pull/123/head old-oid=...

Parse the key-value pairs in the extended status after the null character of the report, and show the proper reference name, old-oid and new-oid to the user.

Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
---
 remote.c                                      | 21 ++++++
 remote.h                                      |  3 +
 send-pack.c                                   | 11 ++-
 t/t5411/test-0032-report-alt.sh               | 14 ++--
 t/t5411/test-0033-report-alt--porcelain.sh    | 14 ++--
 .../test-0036-report-multi-alt-for-one-ref.sh | 12 ++-
 ...report-multi-alt-for-one-ref--porcelain.sh | 12 ++-
 t/t5411/test-0038-report-mixed-refs.sh        |  2 +-
 .../test-0039-report-mixed-refs--porcelain.sh |  2 +-
 transport-helper.c                            | 64 ++++++++--------
 transport.c                                   | 74 +++++++++++++++++--
 11 files changed, 169 insertions(+), 60 deletions(-)
diff --git a/remote.c b/remote.c
index c43196ec06..4174746bb9 100644
--- a/remote.c
+++ b/remote.c
@@ -1,5 +1,6 @@
 #include "cache.h"
 #include "config.h"
+#include "connect.h"
 #include "remote.h"
 #include "refs.h"
 #include "refspec.h"
@@ -2311,3 +2312,23 @@ void apply_push_cas(struct push_cas_option *cas,
 	for (ref = remote_refs; ref; ref = ref->next)
 		apply_cas(cas, remote, ref);
 }
+
+void update_ref_from_remote_status(struct ref *ref)
+{
+	char *val;
+	int len;
+
+	if (!ref->remote_status)
+		return;
+
+	val = (char *)parse_feature_value(ref->remote_status, "old-oid", &len);
+	if (val && len)
+		get_oid_hex(val, &ref->old_oid);
+
+	val = (char *)parse_feature_value(ref->remote_status, "new-oid", &len);
+	if (val && len)
+		get_oid_hex(val, &ref->new_oid);
+
+	if (parse_feature_request(ref->remote_status, "forced-update"))
+		ref->forced_update = 1;
+}
diff --git a/remote.h b/remote.h
index 11d8719b58..09cf7014e3 100644
--- a/remote.h
+++ b/remote.h
@@ -345,4 +345,7 @@ int parseopt_push_cas_option(const struct option *, const char *arg, int unset);
 int is_empty_cas(const struct push_cas_option *);
 void apply_push_cas(struct push_cas_option *, struct remote *, struct ref *);
 
+/* Parse key-value pairs of remote_status and update the reference accordingly */
+void update_ref_from_remote_status(struct ref *ref);
+
 #endif
diff --git a/send-pack.c b/send-pack.c
index a7c53193c9..6e2c7a0c0c 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -159,6 +159,9 @@ static int receive_status(struct packet_reader *reader, struct ref *refs)
 	while (1) {
 		const char *refname;
 		char *msg;
+		char *extended_status = NULL;
+		int len;
+
 		if (packet_reader_read(reader) != PACKET_READ_NORMAL)
 			break;
 		if (!starts_with(reader->line, "ok ") && !starts_with(reader->line, "ng ")) {
@@ -167,10 +170,13 @@ static int receive_status(struct packet_reader *reader, struct ref *refs)
 			break;
 		}
 
+		len = strlen(reader->line);
 		refname = reader->line + 3;
 		msg = strchr(refname, ' ');
 		if (msg)
 			*msg++ = '\0';
+		if (reader->pktlen > len)
+			extended_status = (char *)reader->line + len + 1;
 
 		/* first try searching at our hint, falling back to all refs */
 		if (hint)
@@ -192,7 +198,10 @@ static int receive_status(struct packet_reader *reader, struct ref *refs)
 			hint->status = REF_STATUS_OK;
 		else
 			hint->status = REF_STATUS_REMOTE_REJECT;
-		hint->remote_status = xstrdup_or_null(msg);
+		if (msg)
+			hint->remote_status = xstrdup(msg);
+		else if (extended_status)
+			hint->remote_status = xstrdup_or_null(extended_status);
 		/* start our next search from the next ref */
 		hint = hint->next;
 	}
diff --git a/t/t5411/test-0032-report-alt.sh b/t/t5411/test-0032-report-alt.sh
index dec4afc4c1..bf5faf4f2e 100644
--- a/t/t5411/test-0032-report-alt.sh
+++ b/t/t5411/test-0032-report-alt.sh
@@ -52,7 +52,7 @@ test_expect_success "proc-receive: report alt (alt <ref> <alt-ref>, $PROTOCOL)"
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	 * [new reference] HEAD -> refs/for/master/topic
+	 * [new reference] HEAD -> refs/pull/123/head
 	EOF
 	test_cmp expect actual
 '
@@ -82,7 +82,7 @@ test_expect_success "proc-receive: report alt (alt <ref> <alt-ref> forced-update
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	 * [new reference] HEAD -> refs/for/master/topic
+	 * [new reference] HEAD -> refs/pull/123/head
 	EOF
 	test_cmp expect actual
 '
@@ -112,7 +112,7 @@ test_expect_success "proc-receive: report alt (alt <ref> <alt-ref> old-oid=X, $P
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	 * [new reference] HEAD -> refs/for/master/topic
+	 <OID-B>..<OID-A> HEAD -> refs/pull/123/head
 	EOF
 	test_cmp expect actual
 '
@@ -142,7 +142,7 @@ test_expect_success "proc-receive: report alt (alt <ref> old-oid=X, $PROTOCOL)"
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	 * [new reference] HEAD -> refs/for/master/topic
+	 <OID-B>..<OID-A> HEAD -> refs/for/master/topic
 	EOF
 	test_cmp expect actual
 '
@@ -172,7 +172,7 @@ test_expect_success "proc-receive: report alt (alt <ref> old-oid=X new-oid=Y, $P
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	 * [new reference] HEAD -> refs/for/master/topic
+	 <OID-A>..<OID-B> HEAD -> refs/for/master/topic
 	EOF
 	test_cmp expect actual
 '
@@ -214,9 +214,9 @@ test_expect_success "proc-receive: with multiple alt reports ($PROTOCOL)" '
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/a/b/c/topic
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	 * [new reference] HEAD -> refs/for/next/topic
+	 * [new reference] HEAD -> refs/pull/123/head
 	 * [new reference] HEAD -> refs/for/a/b/c/topic
-	 * [new reference] HEAD -> refs/for/master/topic
+	 + <OID-B>...<OID-A> HEAD -> refs/pull/124/head (forced update)
 	EOF
 	test_cmp expect actual &&
 
diff --git a/t/t5411/test-0033-report-alt--porcelain.sh b/t/t5411/test-0033-report-alt--porcelain.sh
index 49d76892ab..3aea911407 100644
--- a/t/t5411/test-0033-report-alt--porcelain.sh
+++ b/t/t5411/test-0033-report-alt--porcelain.sh
@@ -53,7 +53,7 @@ test_expect_success "proc-receive: report alt (alt <ref> <alt-ref>, --porcelain,
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	*    HEAD:refs/for/master/topic    [new reference]
+	*    HEAD:refs/pull/123/head    [new reference]
 	Done
 	EOF
 	test_cmp expect actual
@@ -84,7 +84,7 @@ test_expect_success "proc-receive: report alt (alt <ref> <alt-ref> forced-update
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	*    HEAD:refs/for/master/topic    [new reference]
+	*    HEAD:refs/pull/123/head    [new reference]
 	Done
 	EOF
 	test_cmp expect actual
@@ -115,7 +115,7 @@ test_expect_success "proc-receive: report alt (alt <ref> <alt-ref> old-oid=X, --
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	*    HEAD:refs/for/master/topic    [new reference]
+	     HEAD:refs/pull/123/head    <OID-B>..<OID-A>
 	Done
 	EOF
 	test_cmp expect actual
@@ -146,7 +146,7 @@ test_expect_success "proc-receive: report alt (alt <ref> old-oid=X, --porcelain,
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	*    HEAD:refs/for/master/topic    [new reference]
+	     HEAD:refs/for/master/topic    <OID-B>..<OID-A>
 	Done
 	EOF
 	test_cmp expect actual
@@ -177,7 +177,7 @@ test_expect_success "proc-receive: report alt (alt <ref> old-oid=X new-oid=Y, --
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	*    HEAD:refs/for/master/topic    [new reference]
+	     HEAD:refs/for/master/topic    <OID-A>..<OID-B>
 	Done
 	EOF
 	test_cmp expect actual
@@ -220,9 +220,9 @@ test_expect_success "proc-receive: with multiple alt reports (--porcelain, $PROT
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/a/b/c/topic
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	*    HEAD:refs/for/next/topic    [new reference]
+	*    HEAD:refs/pull/123/head    [new reference]
 	*    HEAD:refs/for/a/b/c/topic    [new reference]
-	*    HEAD:refs/for/master/topic    [new reference]
+	+    HEAD:refs/pull/124/head    <OID-B>...<OID-A> (forced update)
 	Done
 	EOF
 	test_cmp expect actual &&
diff --git a/t/t5411/test-0036-report-multi-alt-for-one-ref.sh b/t/t5411/test-0036-report-multi-alt-for-one-ref.sh
index fc019f709b..d82b79ffff 100644
--- a/t/t5411/test-0036-report-multi-alt-for-one-ref.sh
+++ b/t/t5411/test-0036-report-multi-alt-for-one-ref.sh
@@ -27,7 +27,9 @@ test_expect_success "proc-receive: report multiple alt, no alt-ref for the 1st r
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	 * [new reference] HEAD -> refs/for/master/topic
+	 <OID-A>..<OID-B> HEAD -> refs/for/master/topic
+	 * [new reference] HEAD -> refs/changes/24/124/1
+	 <OID-A>..<OID-B> HEAD -> refs/changes/25/125/1
 	EOF
 	test_cmp expect actual &&
 	git -C "$upstream" show-ref >out &&
@@ -67,7 +69,9 @@ test_expect_success "proc-receive: report multiple alt, no alt-ref for the 2nd r
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	 * [new reference] HEAD -> refs/for/master/topic
+	 * [new reference] HEAD -> refs/changes/24/124/1
+	 <OID-A>..<OID-B> HEAD -> refs/for/master/topic
+	 + <OID-B>...<OID-A> HEAD -> refs/changes/25/125/1 (forced update)
 	EOF
 	test_cmp expect actual &&
 	git -C "$upstream" show-ref >out &&
@@ -106,6 +110,7 @@ test_expect_success "proc-receive: report ok and alt for the same ref ($PROTOCOL
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
 	 * [new reference] HEAD -> refs/for/master/topic
+	 <OID-A>..<OID-B> HEAD -> refs/changes/24/124/1
 	EOF
 	test_cmp expect actual &&
 	git -C "$upstream" show-ref >out &&
@@ -143,7 +148,8 @@ test_expect_success "proc-receive: report multiple response ($PROTOCOL)" '
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	 * [new reference] HEAD -> refs/for/master/topic
+	 * [new reference] HEAD -> refs/changes/23/123/1
+	 <OID-A>..<OID-B> HEAD -> refs/changes/24/124/2
 	EOF
 	test_cmp expect actual &&
 	git -C "$upstream" show-ref >out &&
diff --git a/t/t5411/test-0037-report-multi-alt-for-one-ref--porcelain.sh b/t/t5411/test-0037-report-multi-alt-for-one-ref--porcelain.sh
index 22607b135e..8cca63c2de 100644
--- a/t/t5411/test-0037-report-multi-alt-for-one-ref--porcelain.sh
+++ b/t/t5411/test-0037-report-multi-alt-for-one-ref--porcelain.sh
@@ -27,7 +27,9 @@ test_expect_success "proc-receive: report multiple alt, no alt-ref for the 1st r
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	*    HEAD:refs/for/master/topic    [new reference]
+	     HEAD:refs/for/master/topic    <OID-A>..<OID-B>
+	*    HEAD:refs/changes/24/124/1    [new reference]
+	     HEAD:refs/changes/25/125/1    <OID-A>..<OID-B>
 	Done
 	EOF
 	test_cmp expect actual &&
@@ -68,7 +70,9 @@ test_expect_success "proc-receive: report multiple alt, no alt-ref for the 2nd r
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	*    HEAD:refs/for/master/topic    [new reference]
+	*    HEAD:refs/changes/24/124/1    [new reference]
+	     HEAD:refs/for/master/topic    <OID-A>..<OID-B>
+	+    HEAD:refs/changes/25/125/1    <OID-B>...<OID-A> (forced update)
 	Done
 	EOF
 	test_cmp expect actual &&
@@ -108,6 +112,7 @@ test_expect_success "proc-receive: report ok and alt for the same ref (--porcela
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
 	*    HEAD:refs/for/master/topic    [new reference]
+	     HEAD:refs/changes/24/124/1    <OID-A>..<OID-B>
 	Done
 	EOF
 	test_cmp expect actual &&
@@ -146,7 +151,8 @@ test_expect_success "proc-receive: report multiple response (--porcelain, $PROTO
 	remote: # post-receive hook
 	remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/master/topic
 	To <URL/of/upstream.git>
-	*    HEAD:refs/for/master/topic    [new reference]
+	*    HEAD:refs/changes/23/123/1    [new reference]
+	     HEAD:refs/changes/24/124/2    <OID-A>..<OID-B>
 	Done
 	EOF
 	test_cmp expect actual &&
diff --git a/t/t5411/test-0038-report-mixed-refs.sh b/t/t5411/test-0038-report-mixed-refs.sh
index dd03bf1538..566cb6e098 100644
--- a/t/t5411/test-0038-report-mixed-refs.sh
+++ b/t/t5411/test-0038-report-mixed-refs.sh
@@ -46,7 +46,7 @@ test_expect_success "proc-receive: report update of mixed refs ($PROTOCOL)" '
 	 * [new branch] HEAD -> baz
 	 * [new reference] HEAD -> refs/for/next/topic
 	 * [new branch] HEAD -> foo
-	 * [new reference] HEAD -> refs/for/master/topic
+	 <OID-A>..<OID-B> HEAD -> refs/for/master/topic
 	EOF
 	test_cmp expect actual &&
 	git -C "$upstream" show-ref >out &&
diff --git a/t/t5411/test-0039-report-mixed-refs--porcelain.sh b/t/t5411/test-0039-report-mixed-refs--porcelain.sh
index e237f40db7..4d617abb1a 100644
--- a/t/t5411/test-0039-report-mixed-refs--porcelain.sh
+++ b/t/t5411/test-0039-report-mixed-refs--porcelain.sh
@@ -46,7 +46,7 @@ test_expect_success "proc-receive: report update of mixed refs (--porcelain, $PR
 	*    HEAD:refs/heads/baz    [new branch]
 	*    HEAD:refs/for/next/topic    [new reference]
 	*    HEAD:refs/heads/foo    [new branch]
-	*    HEAD:refs/for/master/topic    [new reference]
+	     HEAD:refs/for/master/topic    <OID-A>..<OID-B>
 	Done
 	EOF
 	test_cmp expect actual &&
diff --git a/transport-helper.c b/transport-helper.c
index a46afcb69d..0c835c5495 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -747,37 +747,39 @@ static int push_update_ref_status(struct strbuf *buf,
 			msg = xstrdup(msg);
 		strbuf_release(&msg_buf);
 
-		if (!strcmp(msg, "no match")) {
-			status = REF_STATUS_NONE;
-			FREE_AND_NULL(msg);
-		}
-		else if (!strcmp(msg, "up to date")) {
-			status = REF_STATUS_UPTODATE;
-			FREE_AND_NULL(msg);
-		}
-		else if (!strcmp(msg, "non-fast forward")) {
-			status = REF_STATUS_REJECT_NONFASTFORWARD;
-			FREE_AND_NULL(msg);
-		}
-		else if (!strcmp(msg, "already exists")) {
-			status = REF_STATUS_REJECT_ALREADY_EXISTS;
-			FREE_AND_NULL(msg);
-		}
-		else if (!strcmp(msg, "fetch first")) {
-			status = REF_STATUS_REJECT_FETCH_FIRST;
-			FREE_AND_NULL(msg);
-		}
-		else if (!strcmp(msg, "needs force")) {
-			status = REF_STATUS_REJECT_NEEDS_FORCE;
-			FREE_AND_NULL(msg);
-		}
-		else if (!strcmp(msg, "stale info")) {
-			status = REF_STATUS_REJECT_STALE;
-			FREE_AND_NULL(msg);
-		}
-		else if (!strcmp(msg, "forced update")) {
-			forced = 1;
-			FREE_AND_NULL(msg);
+		if (status != REF_STATUS_OK) {
+			if (!strcmp(msg, "no match")) {
+				status = REF_STATUS_NONE;
+				FREE_AND_NULL(msg);
+			}
+			else if (!strcmp(msg, "up to date")) {
+				status = REF_STATUS_UPTODATE;
+				FREE_AND_NULL(msg);
+			}
+			else if (!strcmp(msg, "non-fast forward")) {
+				status = REF_STATUS_REJECT_NONFASTFORWARD;
+				FREE_AND_NULL(msg);
+			}
+			else if (!strcmp(msg, "already exists")) {
+				status = REF_STATUS_REJECT_ALREADY_EXISTS;
+				FREE_AND_NULL(msg);
+			}
+			else if (!strcmp(msg, "fetch first")) {
+				status = REF_STATUS_REJECT_FETCH_FIRST;
+				FREE_AND_NULL(msg);
+			}
+			else if (!strcmp(msg, "needs force")) {
+				status = REF_STATUS_REJECT_NEEDS_FORCE;
+				FREE_AND_NULL(msg);
+			}
+			else if (!strcmp(msg, "stale info")) {
+				status = REF_STATUS_REJECT_STALE;
+				FREE_AND_NULL(msg);
+			}
+			else if (!strcmp(msg, "forced update")) {
+				forced = 1;
+				FREE_AND_NULL(msg);
+			}
 		}
 	}
 
diff --git a/transport.c b/transport.c
index 73defc4a5a..ecdcaae90d 100644
--- a/transport.c
+++ b/transport.c
@@ -463,11 +463,23 @@ static void print_ref_status(char flag, const char *summary,
 			     struct ref *to, struct ref *from, const char *msg,
 			     int porcelain, int summary_width)
 {
+	char *to_name = NULL;
+	const char *val;
+	int len;
+
+	if (to && to->remote_status) {
+		val = parse_feature_value(to->remote_status, "ref", &len);
+		if (val && len)
+			to_name = xmemdupz(val, len);
+	}
+
 	if (porcelain) {
 		if (from)
-			fprintf(stdout, "%c\t%s:%s\t", flag, from->name, to->name);
+			fprintf(stdout, "%c\t%s:%s\t", flag, from->name,
+				to_name ? to_name : to->name);
 		else
-			fprintf(stdout, "%c\t:%s\t", flag, to->name);
+			fprintf(stdout, "%c\t:%s\t", flag,
+				to_name ? to_name : to->name);
 		if (msg)
 			fprintf(stdout, "%s (%s)\n", summary, msg);
 		else
@@ -481,9 +493,11 @@ static void print_ref_status(char flag, const char *summary,
 		fprintf(stderr, " %s%c %-*s%s ", red, flag, summary_width,
 			summary, reset);
 		if (from)
-			fprintf(stderr, "%s -> %s", prettify_refname(from->name), prettify_refname(to->name));
+			fprintf(stderr, "%s -> %s",
+				prettify_refname(from->name),
+				prettify_refname(to_name ? to_name : to->name));
 		else
-			fputs(prettify_refname(to->name), stderr);
+			fputs(prettify_refname(to_name ? to_name : to->name), stderr);
 		if (msg) {
 			fputs(" (", stderr);
 			fputs(msg, stderr);
@@ -491,6 +505,7 @@ static void print_ref_status(char flag, const char *summary,
 		}
 		fputc('\n', stderr);
 	}
+	free(to_name);
 }
 
 static void print_ok_ref_status(struct ref *ref, int porcelain, int summary_width)
@@ -531,8 +546,8 @@ static void print_ok_ref_status(struct ref *ref, int porcelain, int summary_widt
 	}
 }
 
-static int print_one_push_status(struct ref *ref, const char *dest, int count,
-				 int porcelain, int summary_width)
+static int _print_one_push_status(struct ref *ref, const char *dest, int count,
+				  int porcelain, int summary_width)
 {
 	if (!count) {
 		char *url = transport_anonymize_url(dest);
@@ -602,6 +617,53 @@ static int print_one_push_status(struct ref *ref, const char *dest, int count,
 	return 1;
 }
 
+static int print_one_push_status(struct ref *ref, const char *dest, int count,
+				 int porcelain, int summary_width)
+{
+	char *head;
+	char *begin;
+	int n = 0;
+
+	if (!ref->remote_status)
+		return _print_one_push_status(ref, dest, count,
+					      porcelain, summary_width);
+
+	head = ref->remote_status;
+	begin = head;
+	for (;;) {
+		char *end;
+		struct object_id old_oid;
+		struct object_id new_oid;
+		int forced_update;
+
+		end = strstr(begin + 4, "ref=");
+		if (end)
+			*(end-1) = '\0';
+
+		oidcpy(&old_oid, &ref->old_oid);
+		oidcpy(&new_oid, &ref->new_oid);
+		forced_update = ref->forced_update;
+
+		ref->remote_status = begin;
+		update_ref_from_remote_status(ref);
+		_print_one_push_status(ref, dest, count + n++,
+				       porcelain, summary_width);
+
+		oidcpy(&ref->old_oid, &old_oid);
+		oidcpy(&ref->new_oid, &new_oid);
+		ref->forced_update = forced_update;
+
+		if (end) {
+			begin = end;
+			*(end-1) = ' ';
+		} else {
+			break;
+		}
+	}
+	ref->remote_status = head;
+	return n;
+}
+
 static int measure_abbrev(const struct object_id *oid, int sofar)
 {
 	char hex[GIT_MAX_HEXSZ + 1];

-- 
2.24.1.15.g448c31058d.agit.4.5
Previous: Jiang XinNext: Jiang Xin
Message 106 of 266 in “New execute-commands hook for centralized workflow”
  1. 0/7 New execute-commands hook for centralized workflowJiang Xin, Mar 4, 2020
  2. 2/7 receive-pack: feed all commands to post-receiveJiang Xin, Mar 4, 2020
  3. 1/7 receive-pack: new external execute-commands hookJiang Xin, Mar 4, 2020
  4. 3/7 receive-pack: try `execute-commands --pre-receive`Jiang Xin, Mar 4, 2020
  5. 4/7 receive-pack: read env from execute-commands outputJiang Xin, Mar 4, 2020
  6. 5/7 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Mar 4, 2020
  7. 6/7 receive-pack: new config receive.executeCommandsHookRefsJiang Xin, Mar 4, 2020
  8. 7/7 hook: add document and example for "execute-commands" hookJiang Xin, Mar 4, 2020
  9. Junio C HamanoMar 4, 2020
  10. Jiang XinMar 5, 2020
  11. 0/5 New proc-receive hook for centralized workflowJiang Xin, Mar 8, 2020
  12. 1/5 receive-pack: add new proc-receive hookJiang Xin, Mar 8, 2020
  13. Junio C HamanoMar 9, 2020
  14. Jiang XinMar 10, 2020
  15. 0/4 New proc-receive hook for centralized workflowJiang Xin, Mar 13, 2020
  16. 0/5 New proc-receive hook for centralized workflowJiang Xin, Mar 22, 2020
  17. Junio C HamanoMar 25, 2020
  18. 1/5 transport: not report a non-head push as a branchJiang Xin, Mar 22, 2020
  19. Junio C HamanoMar 25, 2020
  20. 3/5 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Mar 22, 2020
  21. 4/5 receive-pack: new config receive.procReceiveRefsJiang Xin, Mar 22, 2020
  22. 2/5 receive-pack: add new proc-receive hookJiang Xin, Mar 22, 2020
  23. 1/3 t5543: never report what we do not pushJiang Xin, Mar 25, 2020
  24. Junio C HamanoMar 25, 2020
  25. Jiang XinMar 26, 2020
  26. 0/3 Never report references we not pushJiang Xin, Mar 25, 2020
  27. 0/4 Never report references we not pushJiang Xin, Mar 29, 2020
  28. Jiang XinMar 29, 2020
  29. 1/5 send-pack: fix inconsistent porcelain outputJiang Xin, Apr 16, 2020
  30. 0/5 fix git-push porcelain output and atomic report issueJiang Xin, Apr 16, 2020
  31. 0/5 fix git-push porcelain output and atomic report issueJiang Xin, Apr 17, 2020
  32. 2/5 t5543: never report what we do not pushJiang Xin, Apr 17, 2020
  33. 1/5 send-pack: fix inconsistent porcelain outputJiang Xin, Apr 17, 2020
  34. Junio C HamanoApr 17, 2020
  35. 4/5 transport-helper: mark failure for atomic pushJiang Xin, Apr 17, 2020
  36. 3/5 send-pack: mark failure of atomic push properlyJiang Xin, Apr 17, 2020
  37. 5/5 transport-helper: new method reject_atomic_push()Jiang Xin, Apr 17, 2020
  38. 2/5 t5543: never report what we do not pushJiang Xin, Apr 16, 2020
  39. 3/5 send-pack: mark failure of atomic push properlyJiang Xin, Apr 16, 2020
  40. 4/5 transport-helper: mark failure for atomic pushJiang Xin, Apr 16, 2020
  41. 5/5 transport-helper: new method reject_atomic_push()Jiang Xin, Apr 16, 2020
  42. 1/4 t5543: never report what we do not pushJiang Xin, Mar 29, 2020
  43. 2/4 send-pack: mark failure of atomic push properlyJiang Xin, Mar 29, 2020
  44. 4/4 transport-helper: new method reject_atomic_push()Jiang Xin, Mar 29, 2020
  45. 3/4 transport-helper: mark failure for atomic pushJiang Xin, Mar 29, 2020
  46. 2/3 send-pack: mark failure of atomic push properlyJiang Xin, Mar 25, 2020
  47. Junio C HamanoMar 25, 2020
  48. 3/3 transport-helper: enforce atomic in push_refs_with_pushJiang Xin, Mar 25, 2020
  49. Junio C HamanoMar 25, 2020
  50. 5/5 receive-pack: refactor report for proc-receiveJiang Xin, Mar 22, 2020
  51. 1/4 receive-pack: add new proc-receive hookJiang Xin, Mar 13, 2020
  52. 2/4 receive-pack: refactor report for proc-receiveJiang Xin, Mar 13, 2020
  53. 4/4 receive-pack: new config receive.procReceiveRefsJiang Xin, Mar 13, 2020
  54. 3/4 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Mar 13, 2020
  55. 2/5 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Mar 8, 2020
  56. 3/5 receive-pack: new config receive.procReceiveRefsJiang Xin, Mar 8, 2020
  57. 4/5 receive-pack: read env from proc-receive outputJiang Xin, Mar 8, 2020
  58. 5/5 hook: add document and example for "proc-receive" hookJiang Xin, Mar 8, 2020
  59. 1/6 transport: not report a non-head push as a branchJiang Xin, Mar 30, 2020
  60. 0/6 New proc-receive hook for centralized workflowJiang Xin, Mar 30, 2020
  61. 4/6 receive-pack: new config receive.procReceiveRefsJiang Xin, Mar 30, 2020
  62. 5/6 receive-pack: refactor report for proc-receiveJiang Xin, Mar 30, 2020
  63. 2/6 receive-pack: add new proc-receive hookJiang Xin, Mar 30, 2020
  64. Junio C HamanoMar 31, 2020
  65. Junio C HamanoMar 31, 2020
  66. 6/6 doc: add documentation for the proc-receive hookJiang Xin, Mar 30, 2020
  67. 3/6 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Mar 30, 2020
  68. 3/7 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Apr 2, 2020
  69. 1/7 transport: not report a non-head push as a branchJiang Xin, Apr 2, 2020
  70. 4/7 receive-pack: new config receive.procReceiveRefsJiang Xin, Apr 2, 2020
  71. 2/7 receive-pack: add new proc-receive hookJiang Xin, Apr 2, 2020
  72. 0/7 New proc-receive hook for centralized workflowJiang Xin, Apr 2, 2020
  73. Junio C HamanoApr 2, 2020
  74. 1/7 transport: not report a non-head push as a branchJiang Xin, Apr 3, 2020
  75. 3/7 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Apr 3, 2020
  76. 2/7 receive-pack: add new proc-receive hookJiang Xin, Apr 3, 2020
  77. 5/7 receive-pack: refactor report for proc-receiveJiang Xin, Apr 3, 2020
  78. 4/7 receive-pack: new config receive.procReceiveRefsJiang Xin, Apr 3, 2020
  79. 0/7 New proc-receive hook for centralized workflowJiang Xin, Apr 3, 2020
  80. 0/7 New proc-receive hook for centralized workflowJiang Xin, Apr 4, 2020
  81. 0/6 New proc-receive hook for centralized workflowJiang Xin, Apr 7, 2020
  82. 1/8 transport: not report a non-head push as a branchJiang Xin, Apr 12, 2020
  83. Junio C HamanoApr 12, 2020
  84. Jiang XinApr 13, 2020
  85. 0/8 New proc-receive hook for centralized workflowJiang Xin, Apr 12, 2020
  86. 0/7 New proc-receive hook for centralized workflowJiang Xin, Apr 13, 2020
  87. 1/7 transport: not report a non-head push as a branchJiang Xin, Apr 13, 2020
  88. 3/7 receive-pack: add new proc-receive hookJiang Xin, Apr 13, 2020
  89. 6/7 receive-pack: new config receive.procReceiveRefsJiang Xin, Apr 13, 2020
  90. 5/7 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Apr 13, 2020
  91. 7/7 doc: add documentation for the proc-receive hookJiang Xin, Apr 13, 2020
  92. 2/7 connect: export parse_feature_value()Jiang Xin, Apr 13, 2020
  93. 4/7 send-pack: extension for client-side status reportJiang Xin, Apr 13, 2020
  94. 3/8 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Apr 12, 2020
  95. Junio C HamanoApr 12, 2020
  96. Jiang XinApr 13, 2020
  97. 2/8 receive-pack: add new proc-receive hookJiang Xin, Apr 12, 2020
  98. Junio C HamanoApr 12, 2020
  99. Jiang XinApr 13, 2020
  100. Junio C HamanoApr 13, 2020
  101. 1/7 transport: not report a non-head push as a branchJiang Xin, Apr 14, 2020
  102. 0/7 New proc-receive hook for centralized workflowJiang Xin, Apr 14, 2020
  103. 1/8 transport: not report a non-head push as a branchJiang Xin, Apr 18, 2020
  104. 0/8 New proc-receive hook for centralized workflowJiang Xin, Apr 18, 2020
  105. 2/8 connect: export parse_feature_value()Jiang Xin, Apr 18, 2020
  106. 4/8 send-pack: extension for client-side status reportJiang Xin, Apr 18, 2020
  107. 8/8 doc: add documentation for the proc-receive hookJiang Xin, Apr 18, 2020
  108. 6/8 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Apr 18, 2020
  109. 7/8 receive-pack: new config receive.procReceiveRefsJiang Xin, Apr 18, 2020
  110. 5/8 receive-pack: feed extended_status to post-receiveJiang Xin, Apr 18, 2020
  111. 3/8 receive-pack: add new proc-receive hookJiang Xin, Apr 18, 2020
  112. 2/7 connect: export parse_feature_value()Jiang Xin, Apr 14, 2020
  113. 3/7 receive-pack: add new proc-receive hookJiang Xin, Apr 14, 2020
  114. Junio C HamanoApr 15, 2020
  115. Jiang XinApr 15, 2020
  116. Junio C HamanoApr 15, 2020
  117. Jiang XinApr 27, 2020
  118. Jeff KingApr 29, 2020
  119. Jiang XinApr 30, 2020
  120. 1/7 transport: not report a non-head push as a branchJiang Xin, May 5, 2020
  121. 0/7 New proc-receive hook for centralized workflowJiang Xin, May 5, 2020
  122. Junio C HamanoMay 6, 2020
  123. Jiang XinMay 7, 2020
  124. Jiang XinMay 7, 2020
  125. 1/7 transport: not report a non-head push as a branchJiang Xin, May 7, 2020
  126. 0/7 New proc-receive hook for centralized workflowJiang Xin, May 7, 2020
  127. 01/11 transport: not report a non-head push as a branchJiang Xin, May 18, 2020
  128. 00/11 New proc-receive hook for centralized workflowJiang Xin, May 18, 2020
  129. 08/10 t5411: test updates of remote-tracking branchesJiang Xin, Aug 15, 2020
  130. 01/10 transport: not report a non-head push as a branchJiang Xin, Aug 15, 2020
  131. 10/10 doc: add documentation for the proc-receive hookJiang Xin, Aug 15, 2020
  132. 06/10 receive-pack: feed report options to post-receiveJiang Xin, Aug 15, 2020
  133. Junio C HamanoAug 17, 2020
  134. 03/10 receive-pack: add new proc-receive hookJiang Xin, Aug 15, 2020
  135. Junio C HamanoAug 17, 2020
  136. 07/10 receive-pack: new config receive.procReceiveRefsJiang Xin, Aug 15, 2020
  137. Junio C HamanoAug 17, 2020
  138. 05/10 doc: add document for capability report-status-v2Jiang Xin, Aug 15, 2020
  139. 02/10 t5411: add basic test cases for proc-receive hookJiang Xin, Aug 15, 2020
  140. 04/10 New capability "report-status-v2" for git-pushJiang Xin, Aug 15, 2020
  141. Junio C HamanoAug 17, 2020
  142. 09/10 transport: parse report options for tracking refsJiang Xin, Aug 15, 2020
  143. 00/10 New proc-receive hook for centralized workflowJiang Xin, Aug 15, 2020
  144. 00/10 New proc-receive hook for centralized workflowJiang Xin, Aug 24, 2020
  145. 01/10 transport: not report a non-head push as a branchJiang Xin, Aug 27, 2020
  146. 00/10 New proc-receive hook for centralized workflowJiang Xin, Aug 27, 2020
  147. Junio C HamanoAug 27, 2020
  148. 02/10 t5411: add basic test cases for proc-receive hookJiang Xin, Aug 27, 2020
  149. 04/10 receive-pack: feed report options to post-receiveJiang Xin, Aug 27, 2020
  150. 07/10 receive-pack: new config receive.procReceiveRefsJiang Xin, Aug 27, 2020
  151. 03/10 receive-pack: add new proc-receive hookJiang Xin, Aug 27, 2020
  152. Johannes SchindelinNov 4, 2020
  153. Johannes SchindelinNov 4, 2020
  154. Jiang XinNov 5, 2020
  155. t5411: fix broken pipe write error on proc-receiveJiang Xin, Nov 5, 2020
  156. Junio C HamanoNov 5, 2020
  157. t5411: consistent result for proc-receive broken testJiang Xin, Nov 7, 2020
  158. Jiang XinNov 9, 2020
  159. t5411: consistent result for proc-receive broken testJiang Xin, Nov 9, 2020
  160. Junio C HamanoNov 9, 2020
  161. Jeff KingNov 9, 2020
  162. Junio C HamanoNov 9, 2020
  163. Jeff KingNov 10, 2020
  164. Jiang XinNov 10, 2020
  165. 1/2 t5411: refactor make_user_friendly_and_stable_outputJiang Xin, Nov 10, 2020
  166. Junio C HamanoNov 10, 2020
  167. Jiang XinNov 11, 2020
  168. 2/2 receive-pack: gently write messages to proc-receiveJiang Xin, Nov 10, 2020
  169. Jeff KingNov 10, 2020
  170. Jiang XinNov 11, 2020
  171. Junio C HamanoNov 10, 2020
  172. Junio C HamanoNov 10, 2020
  173. 1/3 t5411: new helper filter_out_user_friendly_and_stable_outputJiang Xin, Nov 11, 2020
  174. 0/3 jx/t5411-flake-fixJiang Xin, Nov 11, 2020
  175. 2/3 receive-pack: gently write messages to proc-receiveJiang Xin, Nov 11, 2020
  176. 3/3 receive-pack: use default version 0 for proc-receiveJiang Xin, Nov 11, 2020
  177. Jiang XinNov 10, 2020
  178. Junio C HamanoNov 5, 2020
  179. SZEDER GáborJan 17, 2021
  180. Jiang XinJan 18, 2021
  181. SZEDER GáborJan 20, 2021
  182. Jiang XinJan 21, 2021
  183. SZEDER GáborJan 21, 2021
  184. 2/2 t5411: refactor check of refs using test_cmp_refsJiang Xin, Jan 18, 2021
  185. 1/2 t5411: remove file after use to prevent overwritingJiang Xin, Jan 18, 2021
  186. Johannes SixtJan 18, 2021
  187. Jiang XinJan 19, 2021
  188. 1/2 t5411: use different out file to prevent overwritingJiang Xin, Jan 19, 2021
  189. SZEDER GáborJan 20, 2021
  190. 2/2 t5411: refactor check of refs using test_cmp_refsJiang Xin, Jan 21, 2021
  191. 1/2 t5411: use different out file to prevent overwritingJiang Xin, Jan 21, 2021
  192. 0/2 use unique out file in t5411Jiang Xin, Jan 21, 2021
  193. Junio C HamanoFeb 11, 2021
  194. Jiang XinFeb 13, 2021
  195. Jiang XinJan 21, 2021
  196. 2/2 t5411: refactor check of refs using test_cmp_refsJiang Xin, Jan 19, 2021
  197. 0/2 t5411 out file overwrite fixJiang Xin, Jan 19, 2021
  198. 05/10 New capability "report-status-v2" for git-pushJiang Xin, Aug 27, 2020
  199. 08/10 t5411: test updates of remote-tracking branchesJiang Xin, Aug 27, 2020
  200. 09/10 transport: parse report options for tracking refsJiang Xin, Aug 27, 2020
  201. 06/10 doc: add document for capability report-status-v2Jiang Xin, Aug 27, 2020
  202. 10/10 doc: add documentation for the proc-receive hookJiang Xin, Aug 27, 2020
  203. 01/10 transport: not report a non-head push as a branchJiang Xin, Aug 24, 2020
  204. 02/10 t5411: add basic test cases for proc-receive hookJiang Xin, Aug 24, 2020
  205. 03/10 receive-pack: add new proc-receive hookJiang Xin, Aug 24, 2020
  206. 04/10 receive-pack: feed report options to post-receiveJiang Xin, Aug 24, 2020
  207. 06/10 doc: add document for capability report-status-v2Jiang Xin, Aug 24, 2020
  208. 07/10 receive-pack: new config receive.procReceiveRefsJiang Xin, Aug 24, 2020
  209. 08/10 t5411: test updates of remote-tracking branchesJiang Xin, Aug 24, 2020
  210. 09/10 transport: parse report options for tracking refsJiang Xin, Aug 24, 2020
  211. 05/10 New capability "report-status-v2" for git-pushJiang Xin, Aug 24, 2020
  212. 10/10 doc: add documentation for the proc-receive hookJiang Xin, Aug 24, 2020
  213. 02/11 t5411: add basic test cases for proc-receive hookJiang Xin, May 18, 2020
  214. 04/11 New capability "report-status-v2" for git-pushJiang Xin, May 18, 2020
  215. 03/11 receive-pack: add new proc-receive hookJiang Xin, May 18, 2020
  216. 06/11 receive-pack: feed report options to post-receiveJiang Xin, May 18, 2020
  217. 07/11 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, May 18, 2020
  218. 09/11 t5411: test updates of remote-tracking branchesJiang Xin, May 18, 2020
  219. 08/11 receive-pack: new config receive.procReceiveRefsJiang Xin, May 18, 2020
  220. 10/11 transport: parse report options for tracking refsJiang Xin, May 18, 2020
  221. 11/11 doc: add documentation for the proc-receive hookJiang Xin, May 18, 2020
  222. 05/11 doc: add document for capability report-status-v2Jiang Xin, May 18, 2020
  223. 4/7 receive-pack: feed report options to post-receiveJiang Xin, May 7, 2020
  224. 3/7 New capability "report-status-v2" for git-pushJiang Xin, May 7, 2020
  225. 5/7 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, May 7, 2020
  226. 2/7 receive-pack: add new proc-receive hookJiang Xin, May 7, 2020
  227. 6/7 receive-pack: new config receive.procReceiveRefsJiang Xin, May 7, 2020
  228. 7/7 doc: add documentation for the proc-receive hookJiang Xin, May 7, 2020
  229. 3/7 New capability "report-status-v2" for git-pushJiang Xin, May 5, 2020
  230. 8/7 fixup! New capability "report-status-v2" for git-pushJiang Xin, May 5, 2020
  231. 4/7 receive-pack: feed report options to post-receiveJiang Xin, May 5, 2020
  232. 7/7 doc: add documentation for the proc-receive hookJiang Xin, May 5, 2020
  233. 6/7 receive-pack: new config receive.procReceiveRefsJiang Xin, May 5, 2020
  234. 2/7 receive-pack: add new proc-receive hookJiang Xin, May 5, 2020
  235. 5/7 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, May 5, 2020
  236. Jeff KingMay 7, 2020
  237. 4/7 send-pack: extension for client-side status reportJiang Xin, Apr 14, 2020
  238. Junio C HamanoApr 15, 2020
  239. 5/7 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Apr 14, 2020
  240. 7/7 doc: add documentation for the proc-receive hookJiang Xin, Apr 14, 2020
  241. 6/7 receive-pack: new config receive.procReceiveRefsJiang Xin, Apr 14, 2020
  242. 6/8 receive-pack: extension for server-side reportJiang Xin, Apr 12, 2020
  243. 8/8 doc: add documentation for the proc-receive hookJiang Xin, Apr 12, 2020
  244. 7/8 send-pack: extension for client-side status reportJiang Xin, Apr 12, 2020
  245. 4/8 receive-pack: new config receive.procReceiveRefsJiang Xin, Apr 12, 2020
  246. Junio C HamanoApr 12, 2020
  247. Jiang XinApr 13, 2020
  248. 5/8 connect: export parse_feature_value()Jiang Xin, Apr 12, 2020
  249. 1/6 transport: not report a non-head push as a branchJiang Xin, Apr 7, 2020
  250. 3/6 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Apr 7, 2020
  251. 2/6 receive-pack: add new proc-receive hookJiang Xin, Apr 7, 2020
  252. 4/6 receive-pack: new config receive.procReceiveRefsJiang Xin, Apr 7, 2020
  253. 6/6 doc: add documentation for the proc-receive hookJiang Xin, Apr 7, 2020
  254. 5/6 receive-pack: refactor report for proc-receiveJiang Xin, Apr 7, 2020
  255. 1/7 transport: not report a non-head push as a branchJiang Xin, Apr 4, 2020
  256. 3/7 refs.c: refactor to reuse ref_is_hidden()Jiang Xin, Apr 4, 2020
  257. 4/7 receive-pack: new config receive.procReceiveRefsJiang Xin, Apr 4, 2020
  258. 7/7 doc: add documentation for the proc-receive hookJiang Xin, Apr 4, 2020
  259. 2/7 receive-pack: add new proc-receive hookJiang Xin, Apr 4, 2020
  260. 5/7 receive-pack: refactor report for proc-receiveJiang Xin, Apr 4, 2020
  261. 6/7 t5412: test the proc-receive hook on HTTP protocolJiang Xin, Apr 4, 2020
  262. 7/7 doc: add documentation for the proc-receive hookJiang Xin, Apr 3, 2020
  263. 6/7 t5412: test proc-receive hook on HTTP protocolJiang Xin, Apr 3, 2020
  264. 5/7 receive-pack: refactor report for proc-receiveJiang Xin, Apr 2, 2020
  265. 7/7 doc: add documentation for the proc-receive hookJiang Xin, Apr 2, 2020
  266. 6/7 t5412: test proc-receive hook on HTTP protocolJiang Xin, Apr 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.