Re: [PATCH v17 06/10] receive-pack: feed report options to post-receive
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 17, 2020, 21:15 UTC
- Message-ID
- <xmqqy2mdynwv.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200815171740.6257-7-worldhello.net@gmail.com>
Jiang Xin <worldhello.net@gmail.com> writes:
Show 9 quoted lines
> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> index 58972aa7cf..a687218167 100644
> --- a/builtin/receive-pack.c
> +++ b/builtin/receive-pack.c
> @@ -777,17 +777,38 @@ static int feed_receive_hook(void *state_, const char **bufp, size_t *sizep)
> {
> struct receive_hook_feed_state *state = state_;
> struct command *cmd = state->cmd;
> + static struct ref_push_report_options *options = NULL;Exactly the same comment as "don't turn helper functions that can be reused into unreusable ones by adding internal states" as one of the previous patches applies here.