Re: [PATCH v2 4/6] t5701: add setup test to remove side-effect dependency

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 20, 2025, 19:52 UTC
Message-ID: <xmqqy0z52rg4.fsf@gitster.g>
In-Reply-To: <CAPSxiM9qRQ2HuTJDmhq_xeCRmn+yUvjXokwEwJE0S4av9Y-TKg@mail.gmail.com>

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:

> Yeah, that is true, I could not notice this as the next commit of the
> patch series
> was able to fix it. I will change it to "echo", with this, it will be better.

If we want to prepare ourselves against any arbitrary garbage the builder may throw at us, using printf with _fixed_ format and feed the potentially arbitrary garbage as its parameter to be interpolated is the safest approach, so writing it as

    printf "agent=git/%s\n" "$(git version | cut ...)"

would signal the readers that whoever wrote it knew what they were doing and was being extra careful.

THanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.