From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 20 Jan 2025 19:52:43 GMT
Subject: Re: [PATCH v2 4/6] t5701: add setup test to remove side-effect dependency
Message-ID: <xmqqy0z52rg4.fsf@gitster.g>
In-Reply-To: <CAPSxiM9qRQ2HuTJDmhq_xeCRmn+yUvjXokwEwJE0S4av9Y-TKg@mail.gmail.com>

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:

> Yeah, that is true, I could not notice this as the next commit of the
> patch series
> was able to fix it. I will change it to "echo", with this, it will be better.

If we want to prepare ourselves against any arbitrary garbage the
builder may throw at us, using printf with _fixed_ format and feed
the potentially arbitrary garbage as its parameter to be
interpolated is the safest approach, so writing it as

    printf "agent=git/%s\n" "$(git version | cut ...)"

would signal the readers that whoever wrote it knew what they were
doing and was being extra careful.

THanks.