Re: [PATCH 3/4] connect: advertise OS version
- From
Usman Akinyemi <usmanakinyemi202@gmail.com>
- Date
- Jan 11, 2025, 11:07 UTC
- Message-ID
- <CAPSxiM8kWoAXEvAVtp0C9NUQaas3KN=TMBA-p9o6+8KDQbmBUA@mail.gmail.com>
- In-Reply-To
- <xmqqldvi5v5v.fsf@gitster.g>
On Sat, Jan 11, 2025 at 12:54 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 34 quoted lines
> > Usman Akinyemi <usmanakinyemi202@gmail.com> writes: > > >> First of all, I mentioned "registry of canonical os-version strings" > >> to help the users of the "Please use this string" so their server do > >> not have to suffer from different names and spellings to identify > >> the same class of clients. > >> > >> But the server operators that *want* such tighter control *and* are > >> capable of enforcing their choice to their users are probably $CORP > >> in-house operators. They can tell their employees what string to > >> use, or they may even do that in /etc/gitconfig on the machines they > >> give to their users. In other words, they do not need our help at > >> all. > >> > >> At least that is my thought. Others may have different opinions. > > Hi Junio, > > > > Thanks for this. > > > > So instead of having a .format config, we should have a .string config > > which just > > takes a string and uses it as the value for the `os-version` capability ? > > Ah, sorry, I totally misread your patch. I somehow thought you _already_ > have the "any string goes" variant implemented in the patch being reviewed. > > If there isn't any such thing, then my preference is add neither of > the configuration knobs and let the system provided function give a > not-too-specific os-version string (like "Linux"). Once people gain > experiences with that feature, then we will learn more about what > degree of customizability is required. > > Sorry for the confusion.
Hi Junio,
Thanks for this.
Actually, in this patch series, there is a config option called `osVersion.command` The specified command will be run and the output will be used as the value for `os-version` capability. This option was particularly asked by Randall S. Becker in a previous conversation https://lore.kernel.org/git/000a01dac25c$df7b23e0$9e716ba0$@nexbridge.com/
Thank you. Usman