Re: [PATCH 2/4] version: refactor get_uname_info()

From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Jan 8, 2025, 13:06 UTC
Message-ID: <CAPSxiM_Cc+Si1Qoygn7me9jAqfV+B-s3p1uP6=qApnk-Q4X+wA@mail.gmail.com>
In-Reply-To: <xmqqv7usylll.fsf@gitster.g>

Hi Junio

On Mon, Jan 6, 2025 at 9:34 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

>
> Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
>
> > Some code from "builtin/bugreport.c" uses uname(2) to get system
> > information.
> >
> > Let's refactor this code into a new get_uname_info() function, so
> > that we can reuse it in a following commit.
>
> This does two things: refactor and enhancement.  Shouldn't it do
> pure refactoring in a single patch, with a follow-up patch that
> extends it to allow the caller to hide the system details?
>

Thanks for this, I will split the commit into two patches in the next iteration.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.