[PATCH v2 4/6] t5701: add setup test to remove side-effect dependency
- From
Usman Akinyemi <usmanakinyemi202@gmail.com>
- Date
- Jan 17, 2025, 10:46 UTC
- Message-ID
- <20250117104639.65608-5-usmanakinyemi202@gmail.com>
- In-Reply-To
- <20250117104639.65608-1-usmanakinyemi202@gmail.com>
Currently, the "test capability advertisement" test creates some files with expected content which are used by other tests below it.
To remove that side-effect from this test, let's split up part of it into a "setup"-type test which creates the files with expected content which gets reused by multiple tests. This will be useful in a following commit.
Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com> --- t/t5701-git-serve.sh | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/t/t5701-git-serve.sh b/t/t5701-git-serve.sh index de904c1655..0c0a5b2aec 100755 --- a/t/t5701-git-serve.sh +++ b/t/t5701-git-serve.sh @@ -7,14 +7,17 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME . ./test-lib.sh -test_expect_success 'test capability advertisement' ' +test_expect_success 'setup to generate files with expected content' ' + printf "agent=git/$(git version | cut -d" " -f3)" >agent_and_osversion && + test_oid_cache <<-EOF && wrong_algo sha1:sha256 wrong_algo sha256:sha1 EOF + cat >expect.base <<-EOF && version 2 - agent=git/$(git version | cut -d" " -f3) + $(cat agent_and_osversion) ls-refs=unborn fetch=shallow wait-for-done server-option @@ -23,6 +26,9 @@ test_expect_success 'test capability advertisement' ' cat >expect.trailer <<-EOF && 0000 EOF +' + +test_expect_success 'test capability advertisement' ' cat expect.base expect.trailer >expect && GIT_TEST_SIDEBAND_ALL=0 test-tool serve-v2 \
-- 2.48.0