Re: [PATCH 2/4] version: refactor get_uname_info()

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2025, 16:04 UTC
Message-ID: <xmqqv7usylll.fsf@gitster.g>
In-Reply-To: <20250106103713.1452035-3-usmanakinyemi202@gmail.com>

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:

Show 5 quoted lines

> Some code from "builtin/bugreport.c" uses uname(2) to get system
> information.
>
> Let's refactor this code into a new get_uname_info() function, so
> that we can reuse it in a following commit.

This does two things: refactor and enhancement. Shouldn't it do pure refactoring in a single patch, with a follow-up patch that extends it to allow the caller to hide the system details?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.