Re: [PATCH 3/4] connect: advertise OS version

From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Jan 13, 2025, 18:26 UTC
Message-ID: <CAPSxiM93asot47GgfK3ExNWd9M-4fjbWzRWQ=koCFdA8rNwD7g@mail.gmail.com>
In-Reply-To: <xmqqmsfubtt8.fsf@gitster.g>

On Mon, Jan 13, 2025 at 9:16 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

>
> Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
>
> > Actually, in this patch series, there is a config option called
> > `osVersion.command`
> > The specified command will be run and the output will be used as the
> > value for `os-version`
> > capability.
>
> That is essentially a "you can throw at us any arbitrary string".
> So my recommendation would not change.  .format would not give us
> much _additional_ value in such a case.

Hi Junio,

Thanks for this. So, from what I understand, the feature and config option introduced by this patch series is enough, no need to introduce another .format config. Right ?

Thanks.