Re: [PATCH 3/4] connect: advertise OS version

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 13, 2025, 19:47 UTC
Message-ID: <xmqqfrlm8pim.fsf@gitster.g>
In-Reply-To: <CAPSxiM93asot47GgfK3ExNWd9M-4fjbWzRWQ=koCFdA8rNwD7g@mail.gmail.com>

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:

Show 19 quoted lines

> On Mon, Jan 13, 2025 at 9:16 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
>>
>> > Actually, in this patch series, there is a config option called
>> > `osVersion.command`
>> > The specified command will be run and the output will be used as the
>> > value for `os-version`
>> > capability.
>>
>> That is essentially a "you can throw at us any arbitrary string".
>> So my recommendation would not change.  .format would not give us
>> much _additional_ value in such a case.
> Hi Junio,
>
> Thanks for this.  So, from what I understand, the feature and config
> option introduced by
> this patch series is enough, no need to introduce another .format
> config. Right ?

Yup.

At least until we and our userbase gain more experience with the feature.

Thanks.