Re: [PATCH v2] ci: allow per-branch config for GitHub Actions

From: Junio C Hamano <gitster@pobox.com>
Date: May 7, 2020, 19:53 UTC
Message-ID: <xmqqwo5n34ka.fsf@gitster.c.googlers.com>
In-Reply-To: <20200507162011.GA3638906@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> +        - id: check-ref
> +          name: check whether CI is enabled for ref
> +          run: |
> +            enabled=yes
> +            if test -x config-repo/ci/config/allow-ref &&
> +               ! config-repo/ci/config/allow-ref '${{ github.ref }}'

Is it deliberate that the output from the script is not redirected to >/dev/null, which would mean they are allowed to do something that looks like:

		echo "::set-output name=enabled::frotz"

or emit other random ::string-that-affects-github-actions to its standard output stream?

> +            then
> +              enabled=no
> +            fi
> +            echo "::set-output name=enabled::$enabled"

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.