Re: [PATCH v3 2/3] CI: limit GitHub Actions to designated branches

From: Jeff King <peff@peff.net>
Date: May 5, 2020, 16:51 UTC
Message-ID: <20200505165125.GC64077@coredump.intra.peff.net>
In-Reply-To: <a4c6f687c0a8ce55863a19a1c4048438f02803b5.1588695295.git.congdanhqx@gmail.com>

On Tue, May 05, 2020 at 11:26:40PM +0700, Đoàn Trần Công Danh wrote:

Show 11 quoted lines

> -on: [push, pull_request]
> +on:
> +  pull_request:
> +  push:
> +    branches:
> +      - maint
> +      - master
> +      - next
> +      - jch
> +      - pu
> +      - 'for-ci**'

Should this be "for-ci/**", or are we intending for "for-ci-foo" to work? I'd suspect anybody who uses this would use a full directory namespace in a refspec (like "refs/heads/*:refs/heads/for-ci/*"). It might be simpler conceptually to only support that.

> +    tags:
> +      - '**'
> +      - '!**wip**'

IMHO this "wip" match is going too far. That was the name in the example I used, but really it could have been anything. I think we should either:

  - just build all tags; it usually takes special effort to push them up
    anyway, so a one-off "just mark this spot" tag likely wouldn't get
    pushed anyway

  - just build v[0-9]*, which would catch actual releases

-Peff