Re: [PATCH v2 1/2] CI: limit GitHub Actions to designated branches
- From
Jeff King <peff@peff.net>
- Date
- May 5, 2020, 18:24 UTC
- Message-ID
- <20200505182418.GA66702@coredump.intra.peff.net>
- In-Reply-To
- <xmqqo8r2b6y4.fsf@gitster.c.googlers.com>
On Tue, May 05, 2020 at 10:57:39AM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> Would it be too much hassle to use notes for a thing like this? > Perhaps push out with refs/notes/skip-ci note attached to a commit > you do not want to be built? I have a feeling that it gives way > overkill flexibility with little gain (probably too cumbersome to > manage).
I think using notes would be a hassle. This config is really associated with a branch, not a particular config (so you'd have to make sure they propagate across rebases, etc).
But _if_ we can read from other refs in the repository, I would be very happy if we parsed config out of refs/ci/branches or something. It feels like that's something that ought to be possible, but I haven't quite figured out a way to do it.
Really all we want is some kind of per-repo variable storage where the values aren't baked into the tree. There is a "secrets" system that can be used for this, though it kind of feels like an abuse of the concept.
> Does push into GitHub repository offer an ability to pass arbitrary > push option, to which actions that trigger "on: push" event can > react?
No, I don't think so.
-Peff