Re: [PATCH v2] ci: allow per-branch config for GitHub Actions

From: Jeff King <peff@peff.net>
Date: May 7, 2020, 17:18 UTC
Message-ID: <20200507171840.GA3645692@coredump.intra.peff.net>
In-Reply-To: <20200507170042.GC26677@syl.local>

On Thu, May 07, 2020 at 11:00:42AM -0600, Taylor Blau wrote:

Show 8 quoted lines

> >    windows-build:
> > +    needs: ci-config
> > +    if: needs.ci-config.outputs.enabled == 'yes'
> 
> One thing I wonder is whether the downstream 'windows-test' partitions.
> I think that it should be fine, since we won't run the dependent
> 'windows-build', and then 'windows-test' won't have all of its
> prerequisites filled.

Yes, I intentionally left them out for that reason. It seemed simpler to just let the skip percolate down the dependency tree.

Show 12 quoted lines

> > +# Sample script for enabling/disabling GitHub Actions CI runs on
> > +# particular refs. By default, CI is run for all branches pushed to
> > +# GitHub. You can override this by dropping the ".sample" from the script,
> > +# editing it, committing, and pushing the result to the "ci-config" branch of
> > +# your repository:
> > +#
> > +#   git checkout -b ci-config
> 
> Should we be recommending '--orphan' instead of '-b' here? It looks
> like when you clone this branch down that you try to get as few bytes as
> possible, so I figure it may be easier to have this be a orphaned
> branch.

No, the whole point of doing the partial clone (rather than using actions/checkout, which doesn't support that) was so people didn't have to deal with the orphan-branch thing.

-Peff