Re: [PATCH v3 1/3] SubmittingPatches: advertise GitHub Actions CI

From: Jeff King <peff@peff.net>
Date: May 5, 2020, 17:07 UTC
Message-ID: <20200505170737.GE64077@coredump.intra.peff.net>
In-Reply-To: <20200505165933.GC927@danh.dev>

On Tue, May 05, 2020 at 11:59:33PM +0700, Đoàn Trần Công Danh wrote:

Show 12 quoted lines

> > > +Alternately, you can use GitHub Actions (which supports testing your changes
> > > +on Linux, macOS, and Windows) by pushing into a branch in your fork
> > > +or opening a GitHub's Pull Request against
> > > +https://github.com/git/git.git or a fork of that repository.
> > 
> > Probably "GitHub Pull Request" would be more idiomatic English.
> 
> I guess you're right.
> 
> Well, I'm not native English speaker.
> I was thinking, this kind of Pull Request is specific to GitHub,
> and it's different from git-request-pull(1), So, I use "'s" :)

Using the possessive "'s" would imply you're talking about GitHub's feature itself. But you're talking about "a" pull request, so I think you want to just GitHub as an adjective, which would not generally be possessive. English is quirky. :)

Show 5 quoted lines

> > When I made a new repository that was not connected, I had to explicitly
> > enable Actions on the site before it would run the workflow file.
> 
> It seems like GitHub Actions will be triggered automatically if GitHub
> finds any files in "$TOPDIR/.github/workflows/*.yml"

It definitely wasn't for me. Try creating a new repo and going to the "Actions" tab. I get a "Get Started with GitHub Actions" page. If I push up a copy of git.git's master, then I get "Workflows aren't being run in this repository" with a big green button to enable.

I'm just not sure if that happens for people who fork git/git instead of making a new repo. I'm reluctant to delete and remake my fork, but I guess it wouldn't be too hard to re-create.

I think it's OK to leave it out for now. Even if this is how it works for a fork, it's not hard to discover what to do if you click the Actions tab.

-Peff