Re: [PATCH v3 1/3] SubmittingPatches: advertise GitHub Actions CI

From: Jeff King <peff@peff.net>
Date: May 5, 2020, 16:47 UTC
Message-ID: <20200505164740.GB64077@coredump.intra.peff.net>
In-Reply-To: <48752d8b164bc0b11f4d82016415811a0b2bf08b.1588695295.git.congdanhqx@gmail.com>

On Tue, May 05, 2020 at 11:26:39PM +0700, Đoàn Trần Công Danh wrote:

Show 6 quoted lines

> From 889cacb689 (ci: configure GitHub Actions for CI/PR, 2020-04-11),
> GitHub Actions was introduced as an alternative CI system for Git
> project.
> 
> Let's advertise it to Git's contributors to help them test Git on
> various platforms before submitting to Git.

I think this makes sense. Two things:

> +Alternately, you can use GitHub Actions (which supports testing your changes
> +on Linux, macOS, and Windows) by pushing into a branch in your fork
> +or opening a GitHub's Pull Request against
> +https://github.com/git/git.git or a fork of that repository.

Probably "GitHub Pull Request" would be more idiomatic English.

Do people need to enable Actions on their forks for the branch push to work? I didn't need to for my fork of git/git, but I'm not sure if that's because I was playing with Actions months ago and forgot, or if having actions enabled on the parent repo makes it work.

When I made a new repository that was not connected, I had to explicitly enable Actions on the site before it would run the workflow file.

-Peff